PERF: Reduce number of times findall is called on XML file #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter types and parameters can be read through once and loaded into a cache straight away and then the lookups done on the cache after that. This prevents a findall() call iterating through the entire XML document every time a new parameter is found.
Profiling with the script provided in #112, we go from 12s to 0.03s for the Definition creation.
closes #112
Checklist