publish: lte and iot article #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gminn
requested review from
bahildebrand and
tyhoff
and removed request for
bahildebrand
tyhoff
reviewed
Dec 13, 2023
There was a problem hiding this comment.
- We stopped calling them pocket articles - the name wasn't doing them justice.
- I think you need to clarify your goal with the article. If the goal is to give a history of all cellular data protocols,
I think you should add some personal story. Introduction:
EDIT - Looks like I read your first introduction and didn't realize you had another introduction down below. I would try to combine the two, and use the excerpt to pull out one of the paragraphs.
- Split up the large paragraphs before the section "Cells, UEs, and eNBs". Some are quite hefty.
- Updated the ordering of text around images - Squashed two introductions into one. - Broke up one large paragraph - Removed References from the TOC - Fixed Interrupt Slack to be linked - Interter & Interrupt (capitalization)
…rupt into gminn/publish-lte-article
tyhoff
approved these changes
Dec 14, 2023
gminn
force-pushed
the
gminn/publish-lte-article
branch
from
a52fac2 to
207fe94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.