Upgrade gut to v9.3.0 to fix gut errors #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: https://github.com/github/gitignore/blob/6eeebe6f49678aacd8311ce079842c971b3ebe96/Godot.gitignore Need to add the .godot folder since it's full of cooked assets. We also now include *.import files as recommended in the docs: https://docs.godotengine.org/en/4.3/tutorials/assets_pipeline/import_process.html#files-generated
Not using any custom settings. Just the defaults. I'm doing this on Godot 4.3. Not sure if that matters.
Fix a ton of gut errors: scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/RunAtCursor.tscn:4 - ext_resource, invalid UID: uid://cr6tvdv0ve6cv - using text path instead: res://addons/gut/gui/play.png scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/RunAtCursor.tscn:5 - ext_resource, invalid UID: uid://6wra5rxmfsrl - using text path instead: res://addons/gut/gui/arrow.png scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/GutBottomPanel.tscn:6 - ext_resource, invalid UID: uid://cr6tvdv0ve6cv - using text path instead: res://addons/gut/gui/play.png scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/GutBottomPanel.tscn:7 - ext_resource, invalid UID: uid://4gyyn12um08h - using text path instead: res://addons/gut/gui/RunResults.tscn || Cannot open file 'res://addons/gut/gui/RunResults.tscn'. || Failed loading resource: res://addons/gut/gui/RunResults.tscn. Make sure resources have been imported by opening the project in the editor at least once. res://addons/gut/gut_plugin.gd|8| Attempt to call function 'create_temp_directory' in base 'null instance' on a null instance. res://addons/gut/gut.gd|1| Parse Error: Could not resolve super class path "res://addons/gut/gut_to_move.gd". res://addons/gut/gui/BottomPanelShortcuts.gd|5| Invalid access to property or key 'editor_shortcuts_path' on a base object of type 'null instance'. res://addons/gut/gui/GutBottomPanel.gd|21| Invalid call. Nonexistent function 'get_rich_text_edit' in base 'MissingNode'. res://addons/gut/gui/GutBottomPanel.gd|52| Attempt to call function 'create_temp_directory' in base 'null instance' on a null instance. res://addons/gut/gui/GutBottomPanel.gd|317| Invalid access to property or key 'run_results' on a base object of type 'Nil'. res://addons/gut/gui/GutBottomPanel.gd|99| Invalid access to property or key 'shortcut_dialog' on a base object of type 'Nil'. Checked out gut tag v9.3.0 and replaced our addons/gut/ folder with their addons/gut/ folder. When running, gut tells us it's copying our config to use as a template, but I don't think we want to delete the template because all repo devs should use it: || GUT Info: Copying [res://.gut_editor_config.json] to [user://gut_temp_directory/gut_editor_config.json] || GUT Warning: File [res://.gut_editor_config.json] has been moved to [user://gut_temp_directory/gut_editor_config.json]. || You can delete res://.gut_editor_config.json || GUT Info: Copying [res://.gut_editor_shortcuts.cfg] to [user://gut_temp_directory/gut_editor_shortcuts.cfg] || GUT Warning: File [res://.gut_editor_shortcuts.cfg] has been moved to [user://gut_temp_directory/gut_editor_shortcuts.cfg]. || You can delete res://.gut_editor_shortcuts.cfg || GUT got some new images that are not imported yet. Please restart Godot. The Gut editor panel seems to work and I can run tests (they don't all pass).
|
I haven't looked at how this interacts with ci. It's easy to do this upgrade yourself. I didn't do any additional fixes, just switched to the new (stable) version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1.
Fix a ton of gut errors:
scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/RunAtCursor.tscn:4 - ext_resource, invalid UID: uid://cr6tvdv0ve6cv - using text path instead: res://addons/gut/gui/play.png
scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/RunAtCursor.tscn:5 - ext_resource, invalid UID: uid://6wra5rxmfsrl - using text path instead: res://addons/gut/gui/arrow.png
scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/GutBottomPanel.tscn:6 - ext_resource, invalid UID: uid://cr6tvdv0ve6cv - using text path instead: res://addons/gut/gui/play.png
scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/GutBottomPanel.tscn:7 - ext_resource, invalid UID: uid://4gyyn12um08h - using text path instead: res://addons/gut/gui/RunResults.tscn
|| Cannot open file 'res://addons/gut/gui/RunResults.tscn'.
|| Failed loading resource: res://addons/gut/gui/RunResults.tscn. Make sure resources have been imported by opening the project in the editor at least once.
res://addons/gut/gut_plugin.gd|8| Attempt to call function 'create_temp_directory' in base 'null instance' on a null instance.
res://addons/gut/gut.gd|1| Parse Error: Could not resolve super class path "res://addons/gut/gut_to_move.gd".
res://addons/gut/gui/BottomPanelShortcuts.gd|5| Invalid access to property or key 'editor_shortcuts_path' on a base object of type 'null instance'.
res://addons/gut/gui/GutBottomPanel.gd|21| Invalid call. Nonexistent function 'get_rich_text_edit' in base 'MissingNode'.
res://addons/gut/gui/GutBottomPanel.gd|52| Attempt to call function 'create_temp_directory' in base 'null instance' on a null instance.
res://addons/gut/gui/GutBottomPanel.gd|317| Invalid access to property or key 'run_results' on a base object of type 'Nil'.
res://addons/gut/gui/GutBottomPanel.gd|99| Invalid access to property or key 'shortcut_dialog' on a base object of type 'Nil'.
Checked out gut tag v9.3.0 and replaced our addons/gut/ folder with
their addons/gut/ folder. When running, gut tells us it's copying our
config to use as a template, but I don't think we want to delete the
template because all repo devs should use it:
|| GUT Info: Copying [res://.gut_editor_config.json] to [user://gut_temp_directory/gut_editor_config.json]
|| GUT Warning: File [res://.gut_editor_config.json] has been moved to [user://gut_temp_directory/gut_editor_config.json].
|| You can delete res://.gut_editor_config.json
|| GUT Info: Copying [res://.gut_editor_shortcuts.cfg] to [user://gut_temp_directory/gut_editor_shortcuts.cfg]
|| GUT Warning: File [res://.gut_editor_shortcuts.cfg] has been moved to [user://gut_temp_directory/gut_editor_shortcuts.cfg].
|| You can delete res://.gut_editor_shortcuts.cfg
|| GUT got some new images that are not imported yet. Please restart Godot.
The Gut editor panel seems to work and I can run tests (they don't all
pass).
This includes #2 because that change touched a lot of these import files and I think this will result in fewer conflicts?