Optimized the code for offsets.py #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's better than mine at least. I'll take it. Thanks Sorry I didn't see this before October ended- I've given it a Hacktoberfest accepted label anyways. I'm in the middle of moving IRL so I don't have everything set up right now. The only possible issue I can see, without having my development environment on-hand right now to test: Let's either separate the re-organized inventory items into a separate PR, or wait to merge. I'll have to fix the OptionMenu code in the GUI to read/display them properly before merging. The rest looks like it shouldn't require any other code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update includes key refactoring and optimizations for improved maintainability:
Constants for Base Offsets: Defined BASE_OFFSET and CHARACTER_OFFSET constants to avoid hardcoding and simplify future adjustments.
Refactored Character Offsets into Classes: Created a Character base class with common attributes (hp, mp, exp, etc.), with each character as a subclass to reduce duplication.
Added Missing Attributes: Added strength and magic attributes to all characters for consistency.
Organized Item Offsets: Grouped item offsets by type (healing, offensive, etc.) for easier reference and updating.