Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated go.mod and added 'type' to meshSpec #138

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

dhruv0000
Copy link
Member

Signed-off-by: dhruv0000 [email protected]Signed-off-by: dhruv0000 [email protected]
Description
This PR fixes of changes in #31 and #33

Notes for Reviewers

  • Added "type" in MeshSpecDefaults in both development and production stage
  • Updated common.SmiConformanceOperation to use RunSMITest
  • Removed redundant SMI Test successful Event notification
  • Updated go.mod to point to master branch of meshkit and meshery-adaptor-library

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@dhruv0000 dhruv0000 requested a review from leecalcote February 2, 2021 01:27
@leecalcote leecalcote merged commit 0d7d7e2 into meshery:master Feb 2, 2021
@leecalcote
Copy link
Member

Will make a release of this adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants