Skip to content

Commit

Permalink
Merge pull request #616 from Alero-Awani/fixdeployment
Browse files Browse the repository at this point in the history
Fix `unknown kind github` error during deployment
  • Loading branch information
leecalcote authored Nov 8, 2024
2 parents faa5d9d + 310f8e1 commit 62f4e18
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions models/meshmodel/core/v1beta1/host.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ func NewDependencyHandler(connectionKind string) (DependencyHandler, error) {
return Kubernetes{}, nil
case "artifacthub":
return ArtifactHub{}, nil
case "github":
return GitHub{}, nil
}
return nil, ErrUnknownKind(fmt.Errorf("unknown kind %s", connectionKind))
}
Expand Down Expand Up @@ -115,3 +117,13 @@ func (k Kubernetes) HandleDependents(_ component.ComponentDefinition, _ *kuberne
func (k Kubernetes) String() string {
return "kubernetes"
}

type GitHub struct{}

func(gh GitHub) HandleDependents(_ component.ComponentDefinition, _ *kubernetes.Client, _, _ bool) (summary string, err error) {
return summary, err
}

func(gh GitHub) String() string {
return "github"
}

0 comments on commit 62f4e18

Please sign in to comment.