K8 describe test #306

Philip-21 · 2023-04-19T15:39:05Z

Description
Recreated Unit test for the K8 describe package
This PR fixes #287

Yes, I signed my commits.

Azanul

Also, you can look into net/http/httptest if it is of sny use here.

Philip-21 · 2023-04-19T18:07:38Z

utils/kubernetes/describe/describe_test.go

+func (m *MockClient) PrependReactor(method string, Name string, reactorFunc func(*http.Request) (*http.Response, error)) {
+	originalDo := m.Do
+
+	_ = func(req http.Request) (*http.Response, error) {
+		//call the reactor funtion for every reqeust
+		resp, err := reactorFunc(&req)
+		if err != nil || resp != nil {
+			// If the reactor function returns a response or error, return it immediately
+			return resp, err
+		}
+		// Otherwise, call the original Do() method
+		return originalDo(req)
+	}
+}


the PrependReactor() returns http Error response, if there are any errors when the DescribeFunc is called with specific options . The code here returns a reactor function for request for the DescribeFunc if the request have errors it returns the error. If it doesnt the originalDo(req) handles the request and returns a response

Philip-21 · 2023-04-19T18:12:15Z

utils/kubernetes/describe/describe_test.go

+	if m.DescribeError != nil && strings.Contains(m.RequestUrl, "describe") {
+		return &http.Response{
+			StatusCode: 404,
+			Body:       io.NopCloser(bytes.NewReader(m.Response)),
+		}, m.DescribeError
+	}
+	return &http.Response{
+		StatusCode: 404,
+		Body:       io.NopCloser(bytes.NewReader(m.Response)),
+	}, m.DescribeError


ok i see , i would change this

Revolyssup · 2023-04-19T17:43:47Z

Hey @Philip-21 , I reviewed this and I still feel see that we are not testing our part of the code. You are testing the describe method on Describer using mock describer. But that function is in kubectl and is already been tested there. The part of code we want to test is still not being tested.

Philip-21 · 2023-04-19T18:13:21Z

Hey @Philip-21 , I reviewed this and I still feel see that we are not testing our part of the code. You are testing the describe method on Describer using mock describer. But that function is in kubectl and is already been tested there. The part of code we want to test is still not being tested.

Ok, What Part of the Code if i may ask.

Philip-21 · 2023-04-20T04:17:36Z

@Aisuko, please i am also waiting for your review on this.

Aisuko · 2023-04-20T04:47:41Z

@Aisuko, please i am also waiting for your review on this.

You are welcome. I saw you are trying to mock api-server response by using http. Maybe we can invite @Revolyssup to give us a review here.

Philip-21 · 2023-04-21T15:59:06Z

@Aisuko, please i am also waiting for your review on this.

@Revolyssup please we are awaiting your review

Philip-21 · 2023-04-30T21:46:35Z

@Revolyssup , @Aisuko from this testcase, i created a mockclient which has an Api and i used a mock http response to handle the request from the mockclient , i just want to show you my progress so far. My testcase keeps failing , I feel it has to do with the MockClient I used as a parameter in the Describe() ,please i need assistance

Aisuko · 2023-05-01T01:09:00Z

utils/kubernetes/describe/describe_test.go

+			if err != nil {
+				t.Errorf("Testcase failed for %s, coudnt get %s got %s, ", tc.Name, tc.ExpectedError, err)
+			}
+


Please follow the golangci-lint advice.

Aisuko · 2023-05-01T01:10:29Z

utils/kubernetes/describe/describe_test.go

+
+		})
+	}
+


And here remove the whitespace

sorry, i've just done that

I saw the CI still gets stuck on the linter below. Maybe you can check it locally, any of go test or golangci-lint is ok.

ok github.com/layer5io/meshkit/utils/kubernetes 0.062s === RUN TestDescribe === RUN TestDescribe/Pod --- FAIL: TestDescribe (0.00s) --- FAIL: TestDescribe/Pod (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x29d50ea]

i ran go test -v locally, it gave me the same error
=== RUN TestDescribe === RUN TestDescribe/Pod --- FAIL: TestDescribe (0.00s) --- FAIL: TestDescribe/Pod (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal 0xc0000005 code=0x0 addr=0x0 pc=0x239398a]
goroutine 20 [running]: testing.tRunner.func1.2({0x2596da0, 0x3aea4e0}) C:/Program Files/Go/src/testing/testing.go:1526 +0x24e testing.tRunner.func1() C:/Program Files/Go/src/testing/testing.go:1529 +0x39f panic({0x2596da0, 0x3aea4e0}) C:/Program Files/Go/src/runtime/panic.go:884 +0x213 github.com/layer5io/meshkit/utils/kubernetes/describe.Describe(0x0, {{0x28360da, 0x5}, {0x283476a, 0x4}, 0x0, 0x0, 0x1})

OK, let me check it.

Make sure your parameter is not nil

The panic is happened in here

meshkit/utils/kubernetes/describe/describe.go

Line 100 in d0a5f69

describer, ok := describe.DescriberFor(kind, &client.RestConfig)

You parameter &client.RestConfig is nil and it will cause panic.

call describe.DescriberFor(kind, &client.RestConfig) Unable to evaluate expression: error evaluating "&client.RestConfig" as argument clientConfig in function k8s.io/kubectl/pkg/describe.DescriberFor: client is nil

Revolyssup · 2023-05-01T17:30:38Z

utils/kubernetes/describe/describe_test.go

+			httpmock.RegisterResponder(tc.clientApi.Method, tc.clientApi.RequestUrl,
+				httpmock.NewStringResponder(tc.clientApi.ResponseCode, tc.clientApi.Response))
+
+			output, err := Describe(tc.Client.Client, tc.Options)


The meshkitkube Client is not passed in any of the above test cases. You will have to initialise one and pass in each test case. It is initialised with a kubeconfig or when nothing is passed then it detects one from KUBECONFIG env variable. You can create a dummy kubeconfig and pass it to meshkitkube.New.

Philip-21 · 2023-05-05T07:31:39Z

@Revolyssup @Aisuko i created a yml file and a meshkit.New() client , but when i ran the testcase this was the error i got
error in loading Kube configs for tests no kind "Job" is registered for version "batch/v1" in scheme "pkg/runtime/scheme.go:100" , please i seem not to understand this

Revolyssup · 2023-05-05T07:34:41Z

@Revolyssup @Aisuko i created a yml file and a meshkit.New() client , but when i ran the testcase this was the error i got error in loading Kube configs for tests no kind "Job" is registered for version "batch/v1" in scheme "pkg/runtime/scheme.go:100" , please i seem not to understand this

The test kubeconfig looks something like the one given here: https://kubernetes.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/
You are passing Kubernetes resources in kubeconfig.

Philip-21 · 2023-05-06T22:13:33Z

@Revolyssup @Aisuko i created a yml file and a meshkit.New() client , but when i ran the testcase this was the error i got error in loading Kube configs for tests no kind "Job" is registered for version "batch/v1" in scheme "pkg/runtime/scheme.go:100" , please i seem not to understand this

Philip-21 · 2023-05-09T06:13:52Z

@Revolyssup @Aisuko
i have adjusted the test.yml file it seems to work well , but looking at the the new code i have in the file,
if err != nil { t.Errorf("Testcase failed for %s, couldn't get %s got %s, ", tc.Name, tc.ExpectedError, err) },
the unit test fails due to this error checked , when running the testcase i got this error message
"Testcase failed for Pod, couldn't get %!s() got Get "https://5.6.7.8/api/v1/namespaces/test/pods/mypod": dial tcp 5.6.7.8:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.".

leecalcote · 2023-05-12T18:14:20Z

Hang in there, @Philip-21. We're rooting for you. 💪

Aisuko · 2023-05-13T02:31:09Z

Hi @Philip-21 , it looks like your HTTP server did not give you a response in the limited duration.

Philip-21 · 2023-05-13T09:14:13Z

Hang in there, @Philip-21. We're rooting for you. 💪

Thanks Lee

Philip-21 · 2023-05-13T09:17:04Z

Hi @Philip-21 , it looks like your HTTP server did not give you a response in the limited duration.

Maybe i would find a way to Increase the timeout for the HTTP client to allow more time for the server to respond

leecalcote · 2023-05-20T17:39:57Z

Hi @Philip-21 , it looks like your HTTP server did not give you a response in the limited duration.

Maybe i would find a way to Increase the timeout for the HTTP client to allow more time for the server to respond

Yes, that sounds about right. Sleeping is not ideal, but is sometimes the only reasonable approach (without undertaking a whole lot more work).

Azanul suggested changes Apr 19, 2023

View reviewed changes

Aisuko self-requested a review May 1, 2023 01:06

Aisuko requested changes May 1, 2023

View reviewed changes

Revolyssup requested changes May 1, 2023

View reviewed changes

Philip-21 force-pushed the k8-describe-test branch from 0e614a0 to ea04f38 Compare May 20, 2023 17:44

Philip-21 closed this May 20, 2023

Philip-21 force-pushed the k8-describe-test branch from ea04f38 to 8648837 Compare May 20, 2023 17:56

Philip-21 deleted the k8-describe-test branch May 20, 2023 18:24

Philip-21 restored the k8-describe-test branch May 20, 2023 18:43

Philip-21 mentioned this pull request May 20, 2023

K8 Unit tests #319

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

K8 describe test #306

K8 describe test #306

Philip-21 commented Apr 19, 2023 •

edited

Loading

Azanul left a comment

This comment was marked as outdated.

Philip-21 Apr 19, 2023

This comment was marked as outdated.

This comment was marked as outdated.

Philip-21 Apr 19, 2023

Revolyssup commented Apr 19, 2023

Philip-21 commented Apr 19, 2023

Philip-21 commented Apr 20, 2023

Aisuko commented Apr 20, 2023

Philip-21 commented Apr 21, 2023

Philip-21 commented Apr 30, 2023 •

edited

Loading

Aisuko May 1, 2023

Aisuko May 1, 2023

Philip-21 May 1, 2023

Aisuko May 1, 2023

Philip-21 May 1, 2023

Aisuko May 1, 2023

Aisuko May 1, 2023

Revolyssup May 1, 2023

Philip-21 commented May 5, 2023

Revolyssup commented May 5, 2023

Philip-21 commented May 6, 2023 •

edited

Loading

Philip-21 commented May 9, 2023 •

edited

Loading

leecalcote commented May 12, 2023

Aisuko commented May 13, 2023

Philip-21 commented May 13, 2023

Philip-21 commented May 13, 2023

leecalcote commented May 20, 2023 •

edited

Loading

K8 describe test #306

K8 describe test #306

Conversation

Philip-21 commented Apr 19, 2023 • edited Loading

Azanul left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

Choose a reason for hiding this comment

Revolyssup commented Apr 19, 2023

Philip-21 commented Apr 19, 2023

Philip-21 commented Apr 20, 2023

Aisuko commented Apr 20, 2023

Philip-21 commented Apr 21, 2023

Philip-21 commented Apr 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Philip-21 commented May 5, 2023

Revolyssup commented May 5, 2023

Philip-21 commented May 6, 2023 • edited Loading

Philip-21 commented May 9, 2023 • edited Loading

leecalcote commented May 12, 2023

Aisuko commented May 13, 2023

Philip-21 commented May 13, 2023

Philip-21 commented May 13, 2023

leecalcote commented May 20, 2023 • edited Loading

Philip-21 commented Apr 19, 2023 •

edited

Loading

Philip-21 commented Apr 30, 2023 •

edited

Loading

Philip-21 commented May 6, 2023 •

edited

Loading

Philip-21 commented May 9, 2023 •

edited

Loading

leecalcote commented May 20, 2023 •

edited

Loading