Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Rename MeshSync Tables. #261

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

theBeginner86
Copy link
Member

@theBeginner86 theBeginner86 commented Oct 16, 2023

Description

Objects -> KubernetesResources
ResourceSpec -> KubernetesResourceSpec
ResourceObjectMeta -> KubernetesResourceObjectMeta
ResourceStatus -> KubernetesResourceStatus
KeyValue -> KubernetesKeyValue

According to slides in Meshery Architecture Deck

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pranav Singh <[email protected]>
Signed-off-by: Pranav Singh <[email protected]>
Signed-off-by: Pranav Singh <[email protected]>
Signed-off-by: Pranav Singh <[email protected]>
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b410227) 2.77% compared to head (725ce74) 2.77%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #261   +/-   ##
======================================
  Coverage    2.77%   2.77%           
======================================
  Files           6       6           
  Lines         397     397           
======================================
  Hits           11      11           
  Misses        385     385           
  Partials        1       1           
Flag Coverage Δ
unittests 2.77% <60.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
meshsync/handlers.go 10.18% <60.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leecalcote leecalcote merged commit bd8f12c into meshery:master Oct 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants