Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update pkg #262

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

theBeginner86
Copy link
Member

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pranav Singh <[email protected]>
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (609b0f5) 2.77% compared to head (d674641) 2.77%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #262   +/-   ##
======================================
  Coverage    2.77%   2.77%           
======================================
  Files           6       6           
  Lines         397     397           
======================================
  Hits           11      11           
  Misses        385     385           
  Partials        1       1           
Flag Coverage Δ
unittests 2.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leecalcote
Copy link
Member

@theBeginner86, recognizing that the hour is late, I encourage you to carry this forward given the critical nature of the fixes needed.

@theBeginner86 theBeginner86 merged commit 9305e59 into meshery:master Oct 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Necessary task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants