Do not treat interpolated expressions as identifiers #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisptrutski
commented
Dec 11, 2024
Comment on lines
127
to
+128
| // Do not allow dynamic tables | ||
| throw new AnalysisError(AnalysisErrorType.INVALID_QUERY); | ||
| throw new AnalysisError(AnalysisErrorType.UNSUPPORTED_EXPRESSION); |
There was a problem hiding this comment.
Decided to leave this open, there may be a safe subset we choose to support in future.
crisptrutski
commented
Dec 11, 2024
Comment on lines
+6
to
+8
| {:ast-walker-1 | ||
| {:tables [] | ||
| :source-columns []} |
There was a problem hiding this comment.
This walker does its best to return a superset, for better or worse, so it keeps chugging along.
Given the later concerns about false positives, we may want to change this in future.
piranha
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs metabase/metabase#51131