Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Clojars deployment #4

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Set up Clojars deployment #4

merged 3 commits into from
Feb 27, 2024

Conversation

tsmacdonald
Copy link
Contributor

@tsmacdonald tsmacdonald commented Feb 20, 2024

Very similar to second-date's.

@tsmacdonald tsmacdonald requested a review from a team February 20, 2024 10:39
@tsmacdonald tsmacdonald self-assigned this Feb 20, 2024
@tsmacdonald tsmacdonald requested a review from camsaul February 20, 2024 10:40
Comment on lines +69 to +43
[:name "Eclipse Public License"]
[:url "http://www.eclipse.org/legal/epl-v10.html"]]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much thought have you put into this choice? For example I think this license has actually been "deprecated" in favor of the EPL 2.0, which is slightly more permissive but also more explicit about patent retaliation.

Copy link
Collaborator

@crisptrutski crisptrutski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave it to someone with more experience and authority to give the final tick, but LGTM

Base automatically changed from abstract-factory-factory-visitor to master February 20, 2024 16:58
@tsmacdonald
Copy link
Contributor Author

Waiting to hear from Sameer re. relicensing (could happen as a separate PR). But I can verify that a manual deploy worked fine: https://clojars.org/io.github.metabase/macaw

@tsmacdonald tsmacdonald requested a review from a team February 21, 2024 11:54
Copy link
Member

@camsaul camsaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@tsmacdonald tsmacdonald merged commit 06fcb15 into master Feb 27, 2024
4 checks passed
@tsmacdonald tsmacdonald deleted the deploy-to-clojars branch February 27, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants