Use EnumMap for callbacks #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisptrutski
force-pushed
the
fold-tree
branch
from
50105e4 to
de0722a
Compare
crisptrutski
force-pushed
the
enum-map
branch
from
fd602ae to
e371958
Compare
|
If we're worried about safety, seems like we have to go whole hog and change the Clojure to use |
|
Would also probably be nice to have a test for an invalid key |
Not any more—now we have type safety to prevent that entirely. |
tsmacdonald
force-pushed
the
enum-map
branch
from
e371958 to
ab981fe
Compare
tsmacdonald
approved these changes
Feb 28, 2024
crisptrutski
commented
Feb 28, 2024
Comment on lines
+32
to
+33
| {(:column callback-keys) #(update %1 :columns conj (.getColumnName ^Column %2)) | ||
| (:table callback-keys) #(update %1 :tables conj (.getName ^Table %2))} |
There was a problem hiding this comment.
nit: I'd rather do the key conversion in walk-query, to avoid duplication in later PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More typesafe and efficient - the map is backed by an array which uses the underlying int representation of each enum.
Small behavior change - the constructor will now throw an exception for unknown callback keys.