-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth via ADFS with MFA support #134
base: master
Are you sure you want to change the base?
Conversation
Implemented MFA support for OAuth authentication via ADFS.
Added rudimentary message dialog to show notification sent to phone message to user.
Thanks for your contribution, will merge this after a few checks |
git-svn-id: https://svn.code.sf.net/p/davmail/code/trunk@3327 3d1905a2-6b24-0410-a738-b14d5a86fcbd
Merged first commit, need some more time for the second one: O365Authenticator is supposed to be headless so user interaction was not an option. However for SMS based authentication there is no way to provide code without such interaction See certificate management for an example:
|
I suggest to show graphical/console information also for case PhoneAppNotification. User should be informed about required action on smartphone. Is in graphical mode possible to show answer from server in some kind of HTML/JavaScript Java viewer in order to reduce MFA implementation effort? |
iirc, both are now supported... |
@SimPilotAdamT Hi, I'm not active in this PR anymore. You can take over. |
In that case I'm going to make my own fork so that I can make changes to the codebase, making it compatible with what's currently here. Going to try to make my own changes anyway, I don't have a lot of time in my hands... |
Add MFA support for OAuth via ADFS.
Add rudimentary message dialog to visualize necessary MFA action.