Fixes #212

[lamoglia]

The change is to load the charts using $(document).ready instead of window.onload to allow charts to render even with page caching enebled (issue #212)

Some logic related to specific turbolinks vesions was removed, need to confirm if it is ok, I haven't seen any side-effects.

[xiaods]

LGTM

[michelson]

Hi , thanks for this code contribution @lamoglia
Have you tested this with turbolinks 5 or < 5 ?
I think remove turbolinks or vanilla js is a no go.
I would like to reproduce the issue #212 , in our dummy application , ¿are you using turbolinks in your app?

[lamoglia]

I've tested with turbolinks (2.5.3).
Why those "page:load" listeners are needed when using turbolinks?
I thought that $(document).ready does that job already.

[michelson]

Hi @lamoglia, Those are the turbolink's $(document).ready listeners needed to trigger the callbacks when page load.
This: $(document).on('page:load', ready) is the jQuery version for turbolinks, the analog for $(document).ready(ready).
In Turbolinks 5 by the way, page:load was changed to turbolinks:load, that's why we implement the referer logic and Turbolink version < 5 and >=5 checks.
we've Turbolinks 5 support merged a month ago from PR #214 , so remove it in this release makes no sense.
are you using turbolinks along with page caching ?

regards

[lamoglia]

Ok, I'll try to update my project's turbolinks to >=5 to see if something goes wrong and report back ASAP

[michelson]

ok, note that you can disable turbolinks caching https://github.com/turbolinks/turbolinks#opting-out-of-caching

[dredupuika]

This is a no go!
The problem is that when rails native view caching is on the first time a chart is rendered it gets wrapped in the onload event. And when turbolinks gets the view it fetches the same html from the cache bypassing encapsulate_js. This way we end up with onload instead of turbolinks:load.

My guess is that on Turbolinks 5 even if it's not an XHR request you should go with turbolinks:load.
Will test this tomorrow.

[dredupuika]

anyhow this fixes it for turbolinks 5!