Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider upgrades for Microsoft.TimeSeriesInsights fix #4097

Merged
merged 11 commits into from
Sep 26, 2024
Merged

Provider upgrades for Microsoft.TimeSeriesInsights fix #4097

merged 11 commits into from
Sep 26, 2024

Conversation

Danny-Cooke-CK
Copy link
Collaborator

Resolves #4095

Microsoft.TimeSeriesInsights Provider became deprecated and was removed so are causing failures

How is this addressed

  • All provider files referencing older versions of azurerm have been updated to 3.112.0 version
  • Where required, the .terraform lock files have been upgraded so they are in line with the provider files
  • terraform-upgrade script has been extended with scripts in place to perform upgrades more efficiently in the future.
  • all template and component versions have been incremented by one to bump and upgrade within already deployed TRE's

@Danny-Cooke-CK Danny-Cooke-CK mentioned this pull request Sep 25, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit d39db66.

♻️ This comment has been updated with latest results.

@Danny-Cooke-CK
Copy link
Collaborator Author

/test-extended

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11040938862 (with refid 37e78870)

(in response to this comment from @Danny-Cooke-CK)

1 similar comment
@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11040938862 (with refid 37e78870)

(in response to this comment from @Danny-Cooke-CK)

tim-p-allen
tim-p-allen approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@tim-p-allen tim-p-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marrobi
marrobi requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main issue is config sample file, but are some other questions.

config.sample.yaml Outdated Show resolved Hide resolved
templates/shared_services/admin-vm/terraform/upgrade.sh Show resolved Hide resolved
templates/shared_services/cyclecloud/terraform/main.tf Show resolved Hide resolved
templates/workspace_services/azureml/porter.yaml Show resolved Hide resolved
@tim-p-allen
Copy link
Collaborator

/test

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/11049941936 (with refid 37e78870)

(in response to this comment from @tim-allen-ck)

@TonyWildish-BH TonyWildish-BH mentioned this pull request Sep 26, 2024
Merged
marrobi
marrobi approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks.

@tim-p-allen
Copy link
Collaborator

/test-force-approve

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit d39db66)

(in response to this comment from @tim-allen-ck)

@Danny-Cooke-CK Danny-Cooke-CK merged commit 0af4c94 into microsoft:main Sep 26, 2024
11 checks passed
@Danny-Cooke-CK Danny-Cooke-CK deleted the provider-upgrades branch September 26, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-p-allen tim-p-allen tim-p-allen approved these changes

@marrobi marrobi marrobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workspace creation blocked due to Azure API depreciation.
4 participants
@Danny-Cooke-CK @tim-p-allen @marrobi @danny-cooke-icl