-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMK Encryption support for resources in templates #4195
CMK Encryption support for resources in templates #4195
Conversation
…2-add-cmk-for-acr-and-sb
…in storage accounts (core/mgmt only)
…2-enable-cmk-encryption-for-stroage-queues-and-tables
…2-cmk-for-templates
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 715a331. ♻️ This comment has been updated with latest results. |
@yuvalyaron do we know what the upgrade behaviour is here? Might be worth incrementing bundles by a major version to prevent easy upgrade? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know when ready :)
ready :) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12400748485 (with refid (in response to this comment from @yuvalyaron) |
Upgrading is not an issue as long as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left Just a little comment
templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/main.tf
Outdated
Show resolved
Hide resolved
/help |
🤖 pr-bot 🤖 Hello! You can use the following commands: (in response to this comment from @yuvalyaron) |
/test-destroy-env |
Destroying PR test environment (RG: rg-tre64081e76)... (run: https://github.com/microsoft/AzureTRE/actions/runs/12452939536) |
PR test environment destroy complete (RG: rg-tre64081e76) |
/test-extended |
🤖 pr-bot 🤖 (in response to this comment from @yuvalyaron) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12453158465 (with refid (in response to this comment from @yuvalyaron) |
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 715a331) (in response to this comment from @yuvalyaron) |
The workspace tests fail because the Terraform code from the base workspace in the old release does not include the newly added variables. This issue should be resolved once a new release is created. |
Resolves #4145
What is being addressed
Added support for CMK encryption for resources in templates.
How is this addressed