Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Azure Virtual Desktop with AAD Join Workspace Service #950

Closed
wants to merge 8 commits into from

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Sep 28, 2021

PR for issue #1014

What is being addressed

Add basic AVD service with AAD join using bicep templates.

Work to do

  • Uninstall action in bundle needs to work - might need all items tagging with the service_id?
  • upload artifacts to accessible storage location ?
  • add firewall rules - https://docs.microsoft.com/en-us/azure/firewall/protect-azure-virtual-desktop
  • Readme moving to docs and having bundle specific documentation
  • Testing(!)
  • User Assignment - " desktop virtualization user" role assignment to application group and Virtual Machine User login to the VM,

@marrobi marrobi added the bundles Creating and deploying bundles/templates label Sep 28, 2021
@marrobi marrobi self-assigned this Sep 28, 2021
@marrobi marrobi changed the base branch from main to develop September 29, 2021 08:36
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Unit Test Results

0 files   -   1  0 suites   - 1   0s ⏱️ - 13m 34s
0 tests  - 15  0 ✔️  - 15  0 💤 ±0  0 ±0 

Results for commit 81fc3bf. ± Comparison against base commit 3244dac.

This pull request removes 15 tests.
test_workspace_creation ‑ test_get_workspace_templates[tre-workspace-base]
test_workspace_creation ‑ test_get_workspace_templates[tre-workspace-innereye]
test_workspace_creation ‑ test_getting_templates[tre-workspace-base]
test_workspace_creation ‑ test_getting_templates[tre-workspace-innereye]
test_workspace_service_creation ‑ test_create_guacamole_service_into_base_workspace
test_workspace_service_creation ‑ test_get_workspace_service_templates[tre-service-azureml]
test_workspace_service_creation ‑ test_get_workspace_service_templates[tre-service-devtestlabs]
test_workspace_service_creation ‑ test_get_workspace_service_templates[tre-service-guacamole]
test_workspace_service_creation ‑ test_get_workspace_service_templates[tre-service-innereye]
test_workspace_service_creation ‑ test_getting_templates[tre-service-azureml]
…

♻️ This comment has been updated with latest results.

@marrobi marrobi linked an issue Oct 8, 2021 that may be closed by this pull request
5 tasks
@marrobi marrobi changed the base branch from develop to main October 11, 2021 14:23
@daltskin daltskin added this to the Backlog milestone Feb 7, 2022
@microsoft microsoft deleted a comment from github-actions bot May 12, 2022
@SvenAelterman
Copy link
Collaborator

SvenAelterman commented May 17, 2022

Additional work noted:

  • Remove localAdminPassword param and generate a new unique value to be stored in the workspace's KV.
  • Update to use latest AVD artifacts: https://wvdportalstorageblob.blob.core.windows.net/galleryartifacts/Configuration_02-23-2022.zip
  • Use the AVD ARM templates to deploy session hosts instead of recreating that in Bicep.
  • Create an availability set for the session hosts.
  • Output the needed hub firewall rules as rules_collection.
  • Create unique ARM deployments by appending the service ID and the deployment timestamp.
  • Update the connection_uri output from Bicep to a shortlink, or update to the April 2022 AVD endpoint URL.
  • Fix the customRdpProperty on the hostpool for TRE purposes (disable drive redirection, disable clipboard)
  • Attempt to configure the session hosts to disable drive redirection and clipboard with policy.
  • Create a parameter for the friendly name of the workspace and the desktop application because those are user-facing. Provide reasonable defaults.
  • Parameter for images. Using custom images might need to be a separate issue.
  • Resolve MD linter errors.

@github-actions
Copy link

Sorry, @SvenAelterman, only users with write access to the repo can run pr-bot commands.

@marrobi
Copy link
Member Author

marrobi commented May 27, 2022

Superseded by #1865

@marrobi marrobi closed this May 27, 2022
@marrobi marrobi deleted the marrobi/avd-aad-workspace-service branch May 27, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bundles Creating and deploying bundles/templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pooled desktops used as a jump box.
3 participants