Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying a custom AksNodeResourceGroupName #759

Closed
wants to merge 15 commits into from
1 change: 1 addition & 0 deletions src/deploy-cromwell-on-azure/Configuration.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public class Configuration : UserAccessibleConfiguration

public abstract class UserAccessibleConfiguration
{
public string AksNodeResourceGroupName { get; set; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I would add would be to validate in Deployer.cs that this is not set for Upgrades (to follow the pattern of most other "initial deployment only" properties). There are already other properties where that's done, it should be in the same place.

Will this also be done in the CoA deployer?

public string IdentityResourceId { get; set; }
public string AzureCloudName { get; set; } = AzureCloudConfig.DefaultAzureCloudName;
public string BatchPrefix { get; set; }
Expand Down
Loading
Loading