-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for specifying a custom AksNodeResourceGroupName #759
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
602d31b
Add support for AksNodeResourceGroupName
MattMcL4475 5285701
add private coa deployment script
MattMcL4475 96591bd
update deployer logic and script
MattMcL4475 b2dad15
latest
MattMcL4475 cb370e4
update args
MattMcL4475 e28afaf
update args
MattMcL4475 e8f501b
updates
MattMcL4475 b1fa38d
add examples
MattMcL4475 4803d38
fix resourcegraphclient baseuri and vnet name
MattMcL4475 b909b14
minor chnge
MattMcL4475 27dfd71
fixes
MattMcL4475 57b76cc
don't make MI owner of RG
MattMcL4475 b08bdc1
update networking in deployer
MattMcL4475 52cdcf8
fix nullref
MattMcL4475 f04e214
fix subnet range
MattMcL4475 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I would add would be to validate in
Deployer.cs
that this is not set for Upgrades (to follow the pattern of most other "initial deployment only" properties). There are already other properties where that's done, it should be in the same place.Will this also be done in the CoA deployer?