Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction training script filename in README and Fix Bug for Step Running Time Display #815

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

UEFI-code
Copy link
Contributor

@UEFI-code UEFI-code commented Nov 22, 2023

change train.py -> e2e_rlhf.py in README.md to avoid reader's confusion

change train.py -> e2e_rlhf.py to avoid reader's confusion
@UEFI-code
Copy link
Contributor Author

@microsoft-github-policy-service agree

@UEFI-code UEFI-code changed the title Correction training script filename Correction training script filename in README and Fix Error with Step Running Time Display Nov 23, 2023
@UEFI-code UEFI-code changed the title Correction training script filename in README and Fix Error with Step Running Time Display Correction training script filename in README and Fix Bug for Step Running Time Display Nov 23, 2023
Copy link
Contributor

@lekurile lekurile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

applications/DeepSpeed-Chat/e2e_rlhf.py Outdated Show resolved Hide resolved
@awan-10 awan-10 merged commit dd0f181 into microsoft:master Dec 11, 2023
2 checks passed
stceum pushed a commit to stceum/DeepSpeedExamples that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants