Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update correct registry Path for Chrome v-221596 #1267

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Update correct registry Path for Chrome v-221596 #1267

merged 5 commits into from
Nov 27, 2023

Conversation

erjenkin
Copy link
Contributor

@erjenkin erjenkin commented Sep 15, 2023 •
edited
Loading

Pull Request (PR) description:
Fixes Rules V-221596 and V-221572 for Chrome

This Pull Request (PR) fixes the following issues:

This fixes #1215 , #1216

Task list:

  • Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@erjenkin erjenkin changed the title Erjenkin/chrome fix1 Update correct registry Path for Chrome v-221596 Sep 15, 2023
@erjenkin erjenkin added this to the 4.19.0 milestone Sep 15, 2023
@erjenkin erjenkin added bug Something isn't working and removed bug Something isn't working labels Sep 15, 2023
@erjenkin erjenkin requested a review from hinderjd November 17, 2023 20:17
hinderjd
hinderjd approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@hinderjd hinderjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erjenkin erjenkin merged commit 8f9b660 into 4.19.0 Nov 27, 2023
1 of 3 checks passed
@erjenkin erjenkin deleted the erjenkin/ChromeFix1 branch November 27, 2023 15:21
@jmetzger-novetta jmetzger-novetta mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinderjd hinderjd hinderjd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@erjenkin @hinderjd