.NET combine Handle and CallHandler #4386
Conversation
LittleLittleCloud
changed the title
| Task<RpcResponse> HandleRequest(RpcRequest request); | ||
| void ReceiveMessage(Message message); | ||
| Task StoreAsync(AgentState state, CancellationToken cancellationToken = default); | ||
| Task<T> ReadAsync<T>(AgentId agentId, CancellationToken cancellationToken = default) where T : IMessage, new(); | ||
| ValueTask PublishEventAsync(CloudEvent item, CancellationToken cancellationToken = default); | ||
| ValueTask PublishEventAsync(string topic, IMessage evt, CancellationToken cancellationToken = default); |
There was a problem hiding this comment.
this is used in other places (eg App.cs) why remove it?
There was a problem hiding this comment.
The IAgentBase is already deleted by recent PR. So this change no longer apply.
Anyway, the idea of moving the overloaded PublishEventAsync as an extension method is to simplify the interface definition
| } | ||
| var payload = item.ProtoData.Unpack(EventTypes.TypeRegistry); | ||
| var convertedPayload = Convert.ChangeType(payload, EventTypes.Types[item.Type]); | ||
| return this.HandleObject(convertedPayload); |
There was a problem hiding this comment.
I don't understand - with this all agents can handle all messages? I don't think that's what you want..... Maybe a quick call to discuss because I'm not understanding it.
There was a problem hiding this comment.
The HandleObject will check if the agent has the right handler to be invoked. If there's no right handler a "Method not found on type {genericInterfaceType.FullName}" will be raised.
Why are these changes needed?
Related issue number
fix #4354
Checks