-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abadawi/skopeo/CVE 2024 28180 #10633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch does not apply correctly to the skopeo source. Does not look like the patch file is actually meant for skopeo's source code directly.
time="2024-10-05T06:22:32Z" level=debug msg="+ cd skopeo-1.14.2"
time="2024-10-05T06:22:32Z" level=debug msg="+ /bin/chmod -Rf a+rX,u+w,g-w,o-w ."
time="2024-10-05T06:22:32Z" level=debug msg="+ /usr/lib/rpm/rpmuncompress /usr/src/mariner/SOURCES/CVE-2023-45288.patch"
time="2024-10-05T06:22:32Z" level=debug msg="+ /bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch -f"
time="2024-10-05T06:22:32Z" level=debug msg="+ /usr/lib/rpm/rpmuncompress /usr/src/mariner/SOURCES/CVE-2024-3727.patch"
time="2024-10-05T06:22:32Z" level=debug msg="+ /bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch -f"
time="2024-10-05T06:22:32Z" level=debug msg="+ /usr/lib/rpm/rpmuncompress /usr/src/mariner/SOURCES/CVE-2024-6104.patch"
time="2024-10-05T06:22:32Z" level=debug msg="+ /bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch -f"
time="2024-10-05T06:22:32Z" level=debug msg="+ /usr/lib/rpm/rpmuncompress /usr/src/mariner/SOURCES/CVE-2024-6104.patch"
time="2024-10-05T06:22:32Z" level=debug msg="+ /bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch -f"
time="2024-10-05T06:22:32Z" level=debug msg="5 out of 5 hunks FAILED -- saving rejects to file vendor/github.com/hashicorp/go-retryablehttp/client.go.rej"
time="2024-10-05T06:22:32Z" level=debug msg="error: Bad exit status from /var/tmp/rpm-tmp.xOC1yt (%prep)"
time="2024-10-05T06:22:32Z" level=debug msg=" Could not canonicalize hostname: 8a060651c000001"
time="2024-10-05T06:22:32Z" level=debug msg=" %changelog not in descending chronological order"
time="2024-10-05T06:22:32Z" level=debug msg=" Bad exit status from /var/tmp/rpm-tmp.xOC1yt (%prep)"
time="2024-10-05T06:22:32Z" level=debug
time="2024-10-05T06:22:32Z" level=debug msg="RPM build warnings:"
time="2024-10-05T06:22:32Z" level=debug
@@ -1,7 +1,7 @@ | |||
Summary: Inspect container images and repositories on registries | |||
Name: skopeo | |||
Version: 1.14.2 | |||
Release: 8%{?dist} | |||
Release: 9%{?dist} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also looks like the patch file is not being applied in the spec
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
What does the PR accomplish, why was it needed?
Fix https://nvd.nist.gov/vuln/detail/CVE-2024-28180 for skopeo.
Change Log
patch skopeo to fix CVE-2024-28180
Does this affect the toolchain?
No
Links to CVEs
Test Methodology