fix: ESLint issues in botbuilder (#4830)

* fix eslint issues in botbuilder * Merge branch 'southworks/update/eslint-packages' into southworks/fix/eslint-issues-botbuilder * remove eslint-plugin-chai-friendly package * remove eslint-plugin-only-warn * cast authorization variable * apply sub-bullet format * apply missing format * update yarn.lock
microsoft · Jan 6, 2025 · a36641b · a36641b
1 parent 228ca6e
commit a36641b
Show file tree

Hide file tree

Showing 52 changed files with 753 additions and 788 deletions.
diff --git a/eslint.config.cjs b/eslint.config.cjs
@@ -38,6 +38,7 @@ module.exports = [
             '**/*.lu',
             '**/*.dialog',
             '**/*.js.map',
+            '**/vendors'
         ],
     },
 

diff --git a/libraries/botbuilder/eslint.config.cjs b/libraries/botbuilder/eslint.config.cjs
diff --git a/libraries/botbuilder/package.json b/libraries/botbuilder/package.json
@@ -36,7 +36,6 @@
     "botframework-schema": "4.1.6",
     "botframework-streaming": "4.1.6",
     "dayjs": "^1.11.13",
-    "eslint-plugin-only-warn": "^1.1.0",
     "filenamify": "^6.0.0",
     "fs-extra": "^11.2.0",
     "htmlparser2": "^9.0.1",
@@ -55,7 +54,7 @@
     "build:rollup": "yarn clean && yarn build && api-extractor run --verbose --local",
     "clean": "rimraf _ts3.4 lib vendors tsconfig.tsbuildinfo",
     "depcheck": "depcheck --config ../../.depcheckrc",
-    "lint": "eslint .",
+    "lint": "eslint . --config ../../eslint.config.cjs",
     "prebuild": "tsup ./node_modules/filenamify/*.js --format cjs --dts --out-dir vendors/filenamify --clean --sourcemap",
     "postbuild": "downlevel-dts lib _ts3.4/lib --checksum",
     "test": "npm-run-all build test:mocha",
@@ -73,4 +72,4 @@
     "src",
     "vendors"
   ]
-}
+}
diff --git a/libraries/botbuilder/src/botFrameworkAdapter.ts b/libraries/botbuilder/src/botFrameworkAdapter.ts
diff --git a/libraries/botbuilder/src/botFrameworkHttpAdapter.ts b/libraries/botbuilder/src/botFrameworkHttpAdapter.ts
@@ -24,7 +24,7 @@ export interface BotFrameworkHttpAdapter {
         req: Request,
         socket: INodeSocket,
         head: INodeBuffer,
-        logic: (context: TurnContext) => Promise<void>
+        logic: (context: TurnContext) => Promise<void>,
     ): Promise<void>;
 
     /**
@@ -35,6 +35,6 @@ export interface BotFrameworkHttpAdapter {
         req: Request,
         socket: INodeDuplex,
         head: INodeBuffer,
-        logic: (context: TurnContext) => Promise<void>
+        logic: (context: TurnContext) => Promise<void>,
     ): Promise<void>;
 }
diff --git a/libraries/botbuilder/src/botFrameworkHttpClient.ts b/libraries/botbuilder/src/botFrameworkHttpClient.ts
@@ -69,12 +69,12 @@ export class BotFrameworkHttpClient implements BotFrameworkClient {
         toUrl: string,
         serviceUrl: string,
         conversationId: string,
-        activity: Activity
+        activity: Activity,
     ): Promise<InvokeResponse<T>> {
         const appCredentials = await this.getAppCredentials(fromBotId, toBotId);
         if (!appCredentials) {
             throw new Error(
-                'BotFrameworkHttpClient.postActivity(): Unable to get appCredentials to connect to the skill'
+                'BotFrameworkHttpClient.postActivity(): Unable to get appCredentials to connect to the skill',
             );
         }
 
@@ -152,7 +152,6 @@ export class BotFrameworkHttpClient implements BotFrameworkClient {
      *
      * @param appId The application id.
      * @param oAuthScope Optional. The OAuth scope.
-     *
      * @returns The app credentials to be used to acquire tokens.
      */
     protected async buildCredentials(appId: string, oAuthScope?: string): Promise<AppCredentials> {

diff --git a/libraries/botbuilder/src/channelServiceHandler.ts b/libraries/botbuilder/src/channelServiceHandler.ts
@@ -30,7 +30,7 @@ export class ChannelServiceHandler extends ChannelServiceHandlerBase {
     constructor(
         private readonly credentialProvider: ICredentialProvider,
         private readonly authConfig: AuthenticationConfiguration,
-        protected readonly channelService = process.env[AuthenticationConstants.ChannelService]
+        protected readonly channelService = process.env[AuthenticationConstants.ChannelService],
     ) {
         super();
 
@@ -62,7 +62,7 @@ export class ChannelServiceHandler extends ChannelServiceHandlerBase {
             this.channelService,
             'unknown',
             undefined,
-            this.authConfig
+            this.authConfig,
         );
     }
 }