Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Generators versions: Add missing directory to workspaces #4801

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ceciliaavila
Copy link
Collaborator

#minor

Description

This PR includes the generators/generator-botbuilder folder to the project's workspaces so the update-versions script can include the package.json file inside this directory.

Specific Changes

  • Added the generators/generator-botbuilder folder to the project's workspaces.
  • Changed version in generators/generator-botbuilder/package.json to 4.1.6 to match the rest of the projects.

Testing

This image shows the generators' .tgz file created with the correct version.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner November 27, 2024 13:32
@coveralls
Copy link

coveralls commented Nov 27, 2024

Pull Request Test Coverage Report for Build 12051367969

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.691%

Totals Coverage Status
Change from base Build 11974700481: 0.0%
Covered Lines: 20517
Relevant Lines: 23070

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 7feb456 into main Nov 27, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/generators-workspaces branch November 27, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants