Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DV Verilator build fixes #31

Merged
merged 5 commits into from
Apr 22, 2024
Merged

DV Verilator build fixes #31

merged 5 commits into from
Apr 22, 2024

Conversation

marnovandermaas
Copy link
Contributor

I'm not sure which Verilator version this needs to run on but I needed the following changes to build with Verilator v5.024.

@marnovandermaas marnovandermaas changed the title Dv fixes for upstream DV Verilator build fixes Apr 22, 2024
kliuMsft
kliuMsft approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@kliuMsft kliuMsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing this - it's been a little while since we run verilator for this testbench.

@kliuMsft kliuMsft merged commit 3b60b21 into microsoft:main Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kliuMsft kliuMsft kliuMsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marnovandermaas @kliuMsft