Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fast commit by default + doc updates #440

Merged
merged 8 commits into from
Jun 5, 2024
Merged

Enable fast commit by default + doc updates #440

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9173700
update docs
badrishc Jun 3, 2024
29566ae
Enable fast commit by default
badrishc Jun 3, 2024
e9da0bd
Merge branch 'main' into badrishc/update-docs
badrishc Jun 4, 2024
b8484cf
remove manual commitAOF from cluster test
vazois Jun 4, 2024
152f61c
update
badrishc Jun 4, 2024
bb87d8c
update
badrishc Jun 4, 2024
ff45fd6
Merge branch 'main' into badrishc/update-docs
badrishc Jun 4, 2024
16755d3
Merge branch 'main' into badrishc/update-docs
badrishc Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/host/defaults.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@
"CheckpointThrottleFlushDelayMs" : 0,

/* Use FastCommit when writing AOF. */
"EnableFastCommit" : false,
"EnableFastCommit" : true,

/* Throttle FastCommit to write metadata once every K commits. */
"FastCommitThrottleFreq" : 1000,
Expand Down
2 changes: 1 addition & 1 deletion libs/server/Servers/GarnetServerOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ public class GarnetServerOptions : ServerOptions
/// <summary>
/// Enable FastCommit mode for TsavoriteLog
/// </summary>
public bool EnableFastCommit = false;
public bool EnableFastCommit = true;

/// <summary>
/// Throttle FastCommit to write metadata once every K commits
Expand Down
2 changes: 0 additions & 2 deletions test/Garnet.test.cluster/ClusterReplicationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ public void ClusterSRNoCheckpointRestartSecondary([Values] bool performRMW, [Val
context.ValidateKVCollectionAgainstReplica(ref context.kvPairs, 1);

// Shutdown secondary
context.nodes[1].Store.CommitAOF(true);
context.nodes[1].Dispose(false);

Thread.Sleep(TimeSpan.FromSeconds(2));
Expand Down Expand Up @@ -250,7 +249,6 @@ public void ClusterSRPrimaryCheckpoint([Values] bool performRMW, [Values] bool d
context.clusterTestUtils.WaitCheckpoint(1, replicaLastSaveTime, logger: context.logger);

// Shutdown secondary
context.nodes[1].Store.CommitAOF(true);
context.nodes[1].Dispose(false);
Thread.Sleep(TimeSpan.FromSeconds(2));

Expand Down
4 changes: 2 additions & 2 deletions test/Garnet.test.cluster/ClusterTestContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public void CreateInstances(
int CommitFrequencyMs = 0,
bool DisableStorageTier = false,
bool EnableIncrementalSnapshots = false,
bool FastCommit = false,
bool FastCommit = true,
int timeout = -1,
bool useTLS = false,
bool useAcl = false,
Expand Down Expand Up @@ -182,7 +182,7 @@ public GarnetServer CreateInstance(
int CommitFrequencyMs = 0,
bool DisableStorageTier = false,
bool EnableIncrementalSnapshots = false,
bool FastCommit = false,
bool FastCommit = true,
int timeout = -1,
int gossipDelay = 5,
bool useTLS = false,
Expand Down
4 changes: 2 additions & 2 deletions test/Garnet.test/TestUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ public static GarnetServer[] CreateGarnetCluster(
int CommitFrequencyMs = 0,
bool DisableStorageTier = false,
bool EnableIncrementalSnapshots = false,
bool FastCommit = false,
bool FastCommit = true,
string authUsername = null,
string authPassword = null,
bool useAcl = false, // NOTE: Temporary until ACL is enforced as default
Expand Down Expand Up @@ -397,7 +397,7 @@ public static GarnetServerOptions GetGarnetServerOptions(
int CommitFrequencyMs = 0,
bool DisableStorageTier = false,
bool EnableIncrementalSnapshots = false,
bool FastCommit = false,
bool FastCommit = true,
string authUsername = null,
string authPassword = null,
bool useAcl = false, // NOTE: Temporary until ACL is enforced as default
Expand Down
8 changes: 3 additions & 5 deletions website/docs/welcome/about-us.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,13 @@ Check out our blog post [here](/blog/brief-history) for more details on our hist
## Contributors

Core Team:
* Badrish Chandramouli, Vasileios Zois, Ted Hart, Yoganand Rajasekaran, Tal Zaccai, Lukas Maas, Darren Gehring, Irina Spiridonova.
* Badrish Chandramouli, Vasileios Zois, Ted Hart, Yoganand Rajasekaran, Tal Zaccai, Lukas Maas, Darren Gehring.
* Email: garnetteam AT microsoft.com

Project Partners:
* Alan Yang, Pradeep Yadav, Alex Dubinkov, Venugopal Latchupatulla.
* Knut Magne Risvik, Sarah Williamson, Narayanan Subramanian, Saurabh Singh, Padmanabh Gupta.
* Kevin Montrose, Matt Tremblay.
* Open-source contributors to [Garnet](https://github.com/microsoft/garnet/contributors).
* Paulus Pärssinen.
badrishc marked this conversation as resolved.
Show resolved Hide resolved
* Open-source and prior contributors to [Garnet](https://github.com/microsoft/garnet/contributors) and FASTER(https://github.com/microsoft/FASTER/contributors) projects.

Prior Contributors:
* Sajjad Rahnama, Gabriela Martinez Sanchez.
* Open-source contributors to [FASTER](https://github.com/microsoft/FASTER/contributors).
Loading