Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bidi): fix signals tests #34209

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Jan 3, 2025

No description provided.

@yury-s yury-s requested a review from dgozman January 3, 2025 20:05
@yury-s yury-s force-pushed the chore-bidi-signals branch from 8d4ecb1 to 24ddf53 Compare January 3, 2025 20:06
@yury-s yury-s merged commit 5a22475 into microsoft:main Jan 3, 2025
28 of 29 checks passed
@yury-s yury-s deleted the chore-bidi-signals branch January 3, 2025 20:37
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Test results for "tests 1"

3 failed
❌ [installation tests] › playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-ubuntu-latest
❌ [installation tests] › playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-ubuntu-latest
❌ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-ubuntu-latest

6 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @ubuntu-20.04-chromium-tip-of-tree
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:52:3 › should remove cookies by name @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:109:1 › should show tracing.group in the action list with location @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37508 passed, 653 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants