Fix infinite recursion for "each _" #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2024 12:05
|
Can you add one more test for |
JordanBoltonMN
approved these changes
Nov 22, 2024
| @@ -42,7 +42,7 @@ import { TypeById } from "../../typeCache"; | |||
| // Drops PQP.LexSettings and PQP.ParseSettings as they're not needed. | |||
| export interface InspectTypeState | |||
| extends PQP.CommonSettings, | |||
| Omit<InspectionSettings, keyof PQP.Lexer.LexSettings | keyof PQP.Parser.ParseSettings> { | |||
| Omit<InspectionSettings, keyof PQP.Lexer.LexSettings | keyof PQP.Parser.ParseSettings> { | |||
There was a problem hiding this comment.
Odd, my prettier keeps this indented. I don't recall changing it any time recently, but did you run npm install to ensure you have the pinned version?
| @@ -515,6 +515,10 @@ export async function dereferencedIdentifierType( | |||
| return Type.AnyInstance; | |||
| } | |||
|
|
|||
| if (deferencedLiteral === "_") { | |||
There was a problem hiding this comment.
I'm afraid this will break let _ = 1 in 1, which is valid Power Query, and something we can properly type.
| @@ -111,6 +111,23 @@ describe(`Inspection - Type`, () => { | |||
| TypeUtils.numberLiteral(false, `1`), | |||
| ), | |||
| )); | |||
|
|
|||
| it(`each _`, async () => | |||
There was a problem hiding this comment.
Mind adding a test for each [foo] and each _[foo] to cover field access as well?
There was a problem hiding this comment.
Actually, I'm not going to block this PR on that. I'll do a follow-up change.
|
@microsoft-github-policy-service agree company="Microsoft" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we come up with a better solution for evaluating the type of "_" in each expressions, we will need to report the type as "Unknown". Right now, there is an infinite recursion when trying to determine its type