Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage of InspectionSettings.eachScopeById #245

Merged
merged 8 commits into from
Dec 3, 2024

Conversation

JordanBoltonMN
Copy link
Contributor

@JordanBoltonMN JordanBoltonMN commented Nov 22, 2024

Long story short, it's to eventually better support type inspection for each expressions. Take for example

Table.AddColumn(tbl, "name", each [value] * [value])

We know the each expression's implicit argument is referencing tbl, but Intellisense doesn't know. This is the initial step towards that by adding a typing for the implicit argument under to EachExpressionScopeItem, which defaults to a value stored under eachScopeById (which when passed around accounts for most of the delta).

Eventually we'll write some hard coded mappings so whenever you reference a library function like Table.AddColumn it'll update eachScopeById.

@JordanBoltonMN JordanBoltonMN merged commit d3063c0 into master Dec 3, 2024
4 checks passed
@JordanBoltonMN JordanBoltonMN deleted the dev/jobolton/implEachScopeById branch December 3, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants