Add usage of InspectionSettings.eachScopeById #245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short, it's to eventually better support type inspection for each expressions. Take for example
Table.AddColumn(tbl, "name", each [value] * [value])
We know the each expression's implicit argument is referencing
tbl
, but Intellisense doesn't know. This is the initial step towards that by adding a typing for the implicit argument under to EachExpressionScopeItem, which defaults to a value stored under eachScopeById (which when passed around accounts for most of the delta).Eventually we'll write some hard coded mappings so whenever you reference a library function like
Table.AddColumn
it'll updateeachScopeById
.