-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Explorer in VS Code Extension and @Test()
Attribute
#2059
Open
sezna
wants to merge
42
commits into
main
Choose a base branch
from
alex/testHarness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezna
requested review from
billti,
swernli,
idavis,
minestarks,
DmitryVasilevsky and
ScottCarda-MS
as code owners
December 12, 2024 21:43
swernli
reviewed
Dec 16, 2024
swernli
reviewed
Dec 16, 2024
swernli
reviewed
Dec 16, 2024
swernli
approved these changes
Dec 16, 2024
billti
approved these changes
Dec 17, 2024
minestarks
reviewed
Dec 17, 2024
minestarks
reviewed
Dec 17, 2024
minestarks
reviewed
Dec 17, 2024
minestarks
reviewed
Dec 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 22, 2024
This was a drive-by update from my work in #2059. Just wanted it in a separate PR to keep the noise down. It seems to have triggered some `prettier` fixes too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for enabling VS Code's Test Explorer functionality in our extension, and it introduces the
@Test()
attribute on callables. It also switches our libraries over to use@Test()
instead of the oldMain
-based pattern.Any callable that takes no arguments can be annotated as a
@Test()
. If it does not crash (viaFact
or otherwise), it is considered a pass. If it does crash, then it is considered a failure.After this PR is in, when you open a .qs file, you'll see this icon:
Clicking this icon will take you to the test explorer:
The test explorer shows all discovered tests in their namespace hierarchy. Clicking the "run" play button on a namespace runs all child tests contained in that namespace. A test turns green if its last run passed, or red if it didn't.
Other features:
"Run Test" button next to the test itself
"Failed test" icon on failed tests
Notes:
[object Object]
as the output of a failed run.updateDocument
is triggered. The test explorer listens for this event to refresh tests for a specific URI. The test discovery code has to scan for tests across an entire package, since tests could be added to a namespace from any file due to explicit namespaces. But only the updates from the new URI are actually populated to the test explorer.Potential future work:
@Test()
(this was deferred for now as I want that experience to integrate with the Debugger service and that requires a bit more work).