[0.74] Fix focus visuals being obscured by adjacent views (#14105)

* TextInput caret becomes visible on non-focused TextInputs on resize (#14091) * TextInput caret becomes visible on non-focused TextInputs on resize * Change files --------- Co-authored-by: React-Native-Windows Bot <[email protected]> * Fix focus visuals being obscured by adjacent views (#14093) * Fix focus visuals being obscured by adjacent views * Change files * update snapshots * Fix uimplemented view * review feedback --------- Co-authored-by: React-Native-Windows Bot <[email protected]> * update change files * update snapshots * Bump .NET Target version in Microsoft.ReactNative.Test.Website.csproj --------- Co-authored-by: React-Native-Windows Bot <[email protected]>
microsoft · Nov 13, 2024 · 242effb · 242effb
1 parent 0a7b24f
commit 242effb
Show file tree

Hide file tree

Showing 18 changed files with 250 additions and 2,986 deletions.
diff --git a/change/react-native-windows-42cade43-cd57-4cd5-97d3-2a35b924d78f.json b/change/react-native-windows-42cade43-cd57-4cd5-97d3-2a35b924d78f.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Fix focus visuals being obscured by adjacent views",
+  "packageName": "react-native-windows",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}
diff --git a/change/react-native-windows-ad145bca-5a3a-45aa-ab7b-35661aa5fe59.json b/change/react-native-windows-ad145bca-5a3a-45aa-ab7b-35661aa5fe59.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "TextInput caret becomes visible on non-focused TextInputs on resize",
+  "packageName": "react-native-windows",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/e2e-test-app-fabric/test/__snapshots__/ButtonComponentTest.test.ts.snap b/packages/e2e-test-app-fabric/test/__snapshots__/ButtonComponentTest.test.ts.snap
@@ -126,11 +126,6 @@ exports[`Button Tests Buttons can be disabled 1`] = `
               },
             ],
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
       {
@@ -143,11 +138,6 @@ exports[`Button Tests Buttons can be disabled 1`] = `
             "Size": "898, 20",
             "Visual Type": "SpriteVisual",
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
     ],
@@ -283,11 +273,6 @@ exports[`Button Tests Buttons can have accessibility labels 1`] = `
               },
             ],
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
       {
@@ -300,11 +285,6 @@ exports[`Button Tests Buttons can have accessibility labels 1`] = `
             "Size": "898, 20",
             "Visual Type": "SpriteVisual",
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
     ],
@@ -431,11 +411,6 @@ exports[`Button Tests Buttons can have accessibility props 1`] = `
             "Size": "898, 20",
             "Visual Type": "SpriteVisual",
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
     ],
@@ -569,11 +544,6 @@ exports[`Button Tests Buttons can have accessibility states 1`] = `
               },
             ],
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
       {
@@ -586,11 +556,6 @@ exports[`Button Tests Buttons can have accessibility states 1`] = `
             "Size": "898, 20",
             "Visual Type": "SpriteVisual",
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
     ],
@@ -726,11 +691,6 @@ exports[`Button Tests Buttons can have custom colors 1`] = `
               },
             ],
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
       {
@@ -743,11 +703,6 @@ exports[`Button Tests Buttons can have custom colors 1`] = `
             "Size": "898, 20",
             "Visual Type": "SpriteVisual",
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
     ],
@@ -859,11 +814,6 @@ exports[`Button Tests Buttons can have custom focusable and accessible props 1`]
             "Size": "898, 20",
             "Visual Type": "SpriteVisual",
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
     ],
@@ -989,11 +939,6 @@ exports[`Button Tests Buttons can have custom focusable and accessible props 2`]
             "Size": "898, 20",
             "Visual Type": "SpriteVisual",
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
     ],
@@ -1105,11 +1050,6 @@ exports[`Button Tests Buttons can have custom focusable and accessible props 3`]
             "Size": "898, 20",
             "Visual Type": "SpriteVisual",
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
     ],
@@ -1303,11 +1243,6 @@ exports[`Button Tests Buttons can have flexbox styling 1`] = `
                       },
                     ],
                   },
-                  {
-                    "Offset": "0, 0, 0",
-                    "Size": "0, 0",
-                    "Visual Type": "SpriteVisual",
-                  },
                 ],
               },
               {
@@ -1320,20 +1255,10 @@ exports[`Button Tests Buttons can have flexbox styling 1`] = `
                     "Size": "41, 20",
                     "Visual Type": "SpriteVisual",
                   },
-                  {
-                    "Offset": "0, 0, 0",
-                    "Size": "0, 0",
-                    "Visual Type": "SpriteVisual",
-                  },
                 ],
               },
             ],
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
       {
@@ -1435,11 +1360,6 @@ exports[`Button Tests Buttons can have flexbox styling 1`] = `
                       },
                     ],
                   },
-                  {
-                    "Offset": "0, 0, 0",
-                    "Size": "0, 0",
-                    "Visual Type": "SpriteVisual",
-                  },
                 ],
               },
               {
@@ -1452,20 +1372,10 @@ exports[`Button Tests Buttons can have flexbox styling 1`] = `
                     "Size": "44, 20",
                     "Visual Type": "SpriteVisual",
                   },
-                  {
-                    "Offset": "0, 0, 0",
-                    "Size": "0, 0",
-                    "Visual Type": "SpriteVisual",
-                  },
                 ],
               },
             ],
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
     ],
@@ -1691,11 +1601,6 @@ exports[`Button Tests Buttons can have flexbox styling with three buttons 1`] =
                       },
                     ],
                   },
-                  {
-                    "Offset": "0, 0, 0",
-                    "Size": "0, 0",
-                    "Visual Type": "SpriteVisual",
-                  },
                 ],
               },
               {
@@ -1708,20 +1613,10 @@ exports[`Button Tests Buttons can have flexbox styling with three buttons 1`] =
                     "Size": "41, 20",
                     "Visual Type": "SpriteVisual",
                   },
-                  {
-                    "Offset": "0, 0, 0",
-                    "Size": "0, 0",
-                    "Visual Type": "SpriteVisual",
-                  },
                 ],
               },
             ],
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
       {
@@ -1823,11 +1718,6 @@ exports[`Button Tests Buttons can have flexbox styling with three buttons 1`] =
                       },
                     ],
                   },
-                  {
-                    "Offset": "0, 0, 0",
-                    "Size": "0, 0",
-                    "Visual Type": "SpriteVisual",
-                  },
                 ],
               },
               {
@@ -1840,20 +1730,10 @@ exports[`Button Tests Buttons can have flexbox styling with three buttons 1`] =
                     "Size": "87, 20",
                     "Visual Type": "SpriteVisual",
                   },
-                  {
-                    "Offset": "0, 0, 0",
-                    "Size": "0, 0",
-                    "Visual Type": "SpriteVisual",
-                  },
                 ],
               },
             ],
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
       {
@@ -1955,11 +1835,6 @@ exports[`Button Tests Buttons can have flexbox styling with three buttons 1`] =
                       },
                     ],
                   },
-                  {
-                    "Offset": "0, 0, 0",
-                    "Size": "0, 0",
-                    "Visual Type": "SpriteVisual",
-                  },
                 ],
               },
               {
@@ -1972,20 +1847,10 @@ exports[`Button Tests Buttons can have flexbox styling with three buttons 1`] =
                     "Size": "44, 20",
                     "Visual Type": "SpriteVisual",
                   },
-                  {
-                    "Offset": "0, 0, 0",
-                    "Size": "0, 0",
-                    "Visual Type": "SpriteVisual",
-                  },
                 ],
               },
             ],
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
     ],
@@ -2111,11 +1976,6 @@ exports[`Button Tests Buttons have default styling 1`] = `
             "Size": "898, 20",
             "Visual Type": "SpriteVisual",
           },
-          {
-            "Offset": "0, 0, 0",
-            "Size": "0, 0",
-            "Visual Type": "SpriteVisual",
-          },
         ],
       },
     ],