Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with the deletion of RGs and Deployments based on tags #238

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Fix an issue with the deletion of RGs and Deployments based on tags #238

merged 4 commits into from
Oct 27, 2023

Conversation

PabloZaiden
Copy link
Contributor

This PR changes the way the RGs and deployments are queried when deleting an environment.

It used to be based on --tag or --query in the az cli, but it seems that the behavior changed recently.

@PabloZaiden PabloZaiden added bug Something isn't working Bicep labels Oct 27, 2023
@PabloZaiden PabloZaiden self-assigned this Oct 27, 2023
@PabloZaiden PabloZaiden marked this pull request as ready for review October 27, 2023 16:44
@PabloZaiden PabloZaiden requested a review from a team as a code owner October 27, 2023 16:44
@github-actions
Copy link

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ EDITORCONFIG editorconfig-checker 1 1 0.01s
✅ REPOSITORY gitleaks yes no 0.15s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

HadwaAbdelhalem
HadwaAbdelhalem approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@HadwaAbdelhalem HadwaAbdelhalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hattan
hattan approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@hattan hattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PabloZaiden PabloZaiden merged commit 10f70c0 into main Oct 27, 2023
5 of 7 checks passed
@PabloZaiden PabloZaiden deleted the pzaidenvoren/fix-delete-all branch October 27, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HadwaAbdelhalem HadwaAbdelhalem HadwaAbdelhalem approved these changes

@hattan hattan hattan approved these changes

Assignees

@PabloZaiden PabloZaiden

Labels
Bicep bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PabloZaiden @hattan @HadwaAbdelhalem