Update CONTRIBUTING.md #4733
Closed
Update CONTRIBUTING.md #4733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisha-bhatia
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
nisha-bhatia
commented
Oct 14, 2024
| | `pnpm format:check` | Validate files are formatted | | ||
| | `pnpm gen-extern-signature` | Regenerate TypeScript signature for decorators(except compiler) | | ||
| | `pnpm change add` | Add a change description | | ||
| | `pnpm lint` | Run linters | | ||
| | `pnpm lint:fix` | Fix autofixable issues | | ||
| | `pnpm regen-samples` | Regen the samples(when the samples test fail) | | ||
| | `pnpm regen-docs` | Regen the reference docs | | ||
| | `pnpm run setup:min` `pnpm run format` | Run the formatter to reformat all files | |
There was a problem hiding this comment.
The setup command needs to be run before pnpm run format can be run :)
There was a problem hiding this comment.
This is specific to the isolated packages though. All those workspace command assume you have built the workspace.
mayhe we can categorize which one only need the min setup and which one the full build
|
No changes needing a change description found. |
|
You can try these changes here
|
|
@nisha-bhatia Closing since there is an open conversation and his is over a month old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.