Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing decorators.. #5173

Closed
wants to merge 39 commits into from
Closed

Missing decorators.. #5173

wants to merge 39 commits into from

Conversation

skywing918
Copy link
Member

@skywing918 skywing918 commented Nov 22, 2024 •
edited
Loading

#3293
Supported in the OpenAPI3 emitter

  • multipleOf
  • uniqueItems
  • maxProperties
  • minProperties

remove the x- resitrction on @extension

@skywing918 skywing918 changed the title [WIP]Missing decorators.Do Not Review Missing decorators.. Nov 28, 2024
@skywing918 skywing918 marked this pull request as ready for review November 28, 2024 04:47
wanlwanl
wanlwanl reviewed Dec 2, 2024
View reviewed changes
.chronus/changes/MissingDecorators-2024-10-22-15-44-1.md Outdated Show resolved Hide resolved
packages/openapi/README.md Outdated Show resolved Hide resolved
packages/openapi/generated-defs/TypeSpec.OpenAPI.ts Outdated Show resolved Hide resolved
packages/openapi/generated-defs/TypeSpec.OpenAPI.ts Outdated Show resolved Hide resolved
packages/openapi/generated-defs/TypeSpec.OpenAPI.ts Outdated Show resolved Hide resolved
packages/openapi3/src/openapi.ts Outdated Show resolved Hide resolved
packages/openapi3/src/openapi.ts Outdated Show resolved Hide resolved
website/src/content/docs/docs/libraries/openapi/reference/decorators.md Outdated Show resolved Hide resolved
website/src/content/docs/docs/libraries/openapi/reference/decorators.md Outdated Show resolved Hide resolved
packages/openapi/src/decorators.ts Outdated Show resolved Hide resolved
skywing918 and others added 17 commits December 6, 2024 13:04
@skywing918
Merge branch 'microsoft:main' into MissingDecorators
d1fc719
check target for minProperties/maxProperties/multipleOf
756d9ce
@skywing918
Merge branch 'main' into MissingDecorators
cef7ff9
up
c853c31
@skywing918
Merge branch 'main' into MissingDecorators
90ad04d
add warning if set minProperties/maxProperties on components.parameters
7223ea6
@skywing918
Merge branch 'main' into MissingDecorators
83d473e
@skywing918
Merge branch 'main' into MissingDecorators
5d95393
@skywing918
Merge branch 'main' into MissingDecorators
d58c960
@skywing918
Merge branch 'main' into MissingDecorators
0f36c61
@skywing918
Merge branch 'main' into MissingDecorators
d706f92
@skywing918
Merge branch 'main' into MissingDecorators
c10252d
@skywing918
Merge branch 'main' into MissingDecorators
3bc31c3
@skywing918
Merge branch 'main' into MissingDecorators
ce5e664
@skywing918
Merge branch 'main' into MissingDecorators
411ab37
@skywing918
Merge branch 'main' into MissingDecorators
4e64cee
@skywing918
Merge branch 'main' into MissingDecorators
dbd01f1
@wanlwanl
Copy link
Member

To be fixed by #5372.
We can still consider adding tests to it. I already make some tests, one thing we need to verify is that we should add them in oas emitter or json schema emitter. I can share with you.

@wanlwanl wanlwanl closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanlwanl wanlwanl wanlwanl left review comments

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees

@chrisradek chrisradek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skywing918 @wanlwanl @chrisradek