Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not start TypeSpec Language Server when there is no workspace opened #5413

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

RodgeFu
Copy link
Contributor

@RodgeFu RodgeFu commented Dec 19, 2024

Do not start TypeSpec Language Server when there is no workspace opened in vscode (i.e. create TypeSpec project scenario) otherwise there may be error notification popup complaining LSP can't start properly which is confusing.

fixes: #5418

@RodgeFu RodgeFu added the ide Issues for VS, VSCode, Monaco, etc. label Dec 19, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 19, 2024

All changed packages have been documented.

  • @typespec/compiler
  • typespec-vscode
Show changes

typespec-vscode - fix ✏️

Do not start TypeSpec Language Server when there is no workspace opened

@typespec/compiler - internal ✏️

Use inspect instead of Json.stringify when logging object in server log

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs 🛝 VSCode Extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide Issues for VS, VSCode, Monaco, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: LSP may show error notification when user creates TypeSpec project but no compiler installed yet
3 participants