Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeProvider #5432

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

live1206
Copy link
Contributor

@live1206 live1206 commented Dec 24, 2024

Needed for Azure/azure-sdk-for-net#47665

  • Update modifiers of TypeProvider
  • Update relativeFilePath of TypeProvdier
  • Make StringExtensions public so that sub-plugins don't need to re-implement
    • move StringExtensions to Microsoft.Generator.CSharp.Input and remove the shared link of it in others
  • remove sealed from ModelProvider, so that ResourceDataProvdier in Azure plugin can share most of the existing logic

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Dec 24, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 24, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp
Microsoft.Generator.CSharp.Input

@live1206 live1206 changed the title Update modifiers for TypeProvider Update TypeProvider Dec 24, 2024
@live1206 live1206 marked this pull request as ready for review December 26, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants