Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to safetly prevent duplicated execution commandline #24416

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Attempt to safetly prevent duplicated execution commandline #24416

wants to merge 2 commits into from

Conversation

anthonykim1
Copy link

@anthonykim1 anthonykim1 commented Nov 11, 2024 •
edited by karthiknadig
Loading

Co-authored-by: Daniel Imms @Tyriar

@anthonykim1 anthonykim1 self-assigned this Nov 11, 2024
@anthonykim1 anthonykim1 changed the title Start on partial keyboard interrupt fixes Attempt to safetly prevent duplicated execution commandline Nov 11, 2024
@anthonykim1
Copy link
Author

To prevent duplicated Terminal REPL execution commandLine (...venv/bin/python etc) and python command, we may still have to await on exitCode for python to return undefined after it has launched REPL in terminal and/or increase timeout of checking for terminal.shellIntegration from 0.5 to longer (Should check settings as the biggest signal, and past terminals as a secondary signal in this case).

@anthonykim1
Copy link
Author

Will handle fix for Keyboard Interrupt in separate PR: mainly from 2044f83

@anthonykim1 anthonykim1 mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@anthonykim1 anthonykim1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anthonykim1