Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LuaJIT): remove invalid build version #132705

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

ateoi
Copy link
Member

@ateoi ateoi commented Jan 4, 2024

Cannot use LuaJIT build version because MSI packages don't accept build version greater than 65536
(https://learn.microsoft.com/windows/win32/msi/productversion). Latest package version was already published by #132340.

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

Cannot use LuaJIT build version because MSI packages don't accept build
version greater than 65536
(https://learn.microsoft.com/windows/win32/msi/productversion).
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Manifest The test to validate that the manifest syntax is correct failed. label Jan 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 5, 2024
@stephengillie
Copy link
Collaborator

Sequence contains no elements

@stephengillie stephengillie added Validation-Completed Validation passed and removed Internal-Error-Manifest The test to validate that the manifest syntax is correct failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 9, 2024
@stephengillie stephengillie enabled auto-merge (squash) January 9, 2024 15:45
@stephengillie stephengillie merged commit 2a69d05 into microsoft:master Jan 9, 2024
3 of 5 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants