-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(LuaJIT): remove invalid build version #132705
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Cannot use LuaJIT build version because MSI packages don't accept build version greater than 65536 (https://learn.microsoft.com/windows/win32/msi/productversion).
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
wingetbot
added
the
Internal-Error-Manifest
The test to validate that the manifest syntax is correct failed.
label
Jan 4, 2024
microsoft-github-policy-service
bot
added
the
Needs-Attention
This work item needs to be reviewed by a member of the core team.
label
Jan 4, 2024
Trenly
approved these changes
Jan 5, 2024
microsoft-github-policy-service
bot
added
the
Moderator-Approved
One of the Moderators has reviewed and approved this PR
label
Jan 5, 2024
|
stephengillie
added
Validation-Completed
Validation passed
and removed
Internal-Error-Manifest
The test to validate that the manifest syntax is correct failed.
Needs-Attention
This work item needs to be reviewed by a member of the core team.
labels
Jan 9, 2024
stephengillie
approved these changes
Jan 9, 2024
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Moderator-Approved
One of the Moderators has reviewed and approved this PR
Publish-Pipeline-Succeeded
Validation-Completed
Validation passed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot use LuaJIT build version because MSI packages don't accept build version greater than 65536
(https://learn.microsoft.com/windows/win32/msi/productversion). Latest package version was already published by #132340.
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow