Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Panic.Playdate version 1.1.0 #136766

Closed
wants to merge 3 commits into from
Closed

New package: Panic.Playdate version 1.1.0 #136766

wants to merge 3 commits into from

Conversation

Exorcism0666
Copy link
Contributor

@Exorcism0666 Exorcism0666 commented Jan 27, 2024 •
edited by microsoft-github-policy-service bot
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 27, 2024
@Exorcism0666
Copy link
Contributor Author

For moderators

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

Important

Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 27, 2024
auto-merge was automatically disabled January 27, 2024 20:41

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Changes-Requested Changes Requested labels Jan 27, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 27, 2024
@stephengillie
Copy link
Collaborator

image

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 29, 2024
auto-merge was automatically disabled January 29, 2024 18:46

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. labels Jan 29, 2024
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 29, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

2024-01-29T19:10:30.0324797Z ##[error] One or more errors occurred. (Manifest: The manifest file path must match PackageIdentifier and PackageVersion properties from manifest. actual 'manifests\p\Panic\Playdate\1.1.0', expected 'manifests\p\Panic\Mirror\1.1.0') Manifest: The manifest file path must match PackageIdentifier and PackageVersion properties from manifest. actual 'manifests\p\Panic\Playdate\1.1.0', expected 'manifests\p\Panic\Mirror\1.1.0'

(Automated response - build 674.)

stephengillie
stephengillie reviewed Jan 29, 2024
View reviewed changes
manifests/p/Panic/Playdate/1.1.0/Panic.Playdate.installer.yaml
# Created using wingetcreate 1.5.7.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.5.0.schema.json

PackageIdentifier: Panic.Mirror
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please update file name and path to match this change.

stephengillie
stephengillie reviewed Jan 29, 2024
View reviewed changes
manifests/p/Panic/Playdate/1.1.0/Panic.Playdate.locale.en-US.yaml
# Created using wingetcreate 1.5.7.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.5.0.schema.json

PackageIdentifier: Panic.Playdate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageIdentifier: Panic.Playdate
PackageIdentifier: Panic.Mirror
  • Please update file name and path to match this change.

stephengillie
stephengillie reviewed Jan 29, 2024
View reviewed changes
manifests/p/Panic/Playdate/1.1.0/Panic.Playdate.yaml
# Created using wingetcreate 1.5.7.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.5.0.schema.json

PackageIdentifier: Panic.Playdate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageIdentifier: Panic.Playdate
PackageIdentifier: Panic.Mirror
  • Please update file name and path to match this change.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Jan 30, 2024
@TheNavyBear
Copy link

Any updates on this? Also, a new version (version 1.2.0) is out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie left review comments

@Trenly Trenly Trenly requested changes

Assignees

@Exorcism0666 Exorcism0666

Labels
Manifest-Validation-Error Manifest validation failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: Playdate Mirror
5 participants
@Exorcism0666 @wingetbot @stephengillie @TheNavyBear @Trenly