Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Viva Goals Apis to graph explorer #397

Conversation

ishatyagiit
Copy link
Contributor

No description provided.

@ishatyagiit ishatyagiit requested a review from a team as a code owner October 27, 2023 10:10
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ishatyagiit

Any chance you can fix the failing CI for the added sections? Ideally the requestUrl is expected to be full absolute URIs and not relative ones.

@ishatyagiit
Copy link
Contributor Author

Thanks for this @ishatyagiit

Any chance you can fix the failing CI for the added sections? Ideally the requestUrl is expected to be full absolute URIs and not relative ones.

Hi @andrueastman ,
Will update doc link once this PR is merged.
https://github.com/microsoftgraph/microsoft-graph-docs/pull/22967

Could you please help us in merging that?

@andrueastman
Copy link
Member

Thanks for confirming. I've looped in the docs team to help out with the review and merge of the docs PR.

@ishatyagiit
Copy link
Contributor Author

Hi @andrueastman ,
We are still waiting for another PR to get merged.
https://github.com/microsoftgraph/microsoft-graph-docs/pull/22967

Wanted to check how much time will this PR take once I update the doc link?

@andrueastman
Copy link
Member

@ishatyagiit Once the links are fixed, I should be able to merge this in for you as soon as I confirm the CI validation checks are passing.

@ishatyagiit
Copy link
Contributor Author

@andrueastman : Can we please check it now and merge ?

@andrueastman andrueastman merged commit b7999e3 into microsoftgraph:dev Nov 21, 2023
4 checks passed
@ishatyagiit
Copy link
Contributor Author

@andrueastman : When can we see these in graph explorer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants