-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send only related exceptions for event creation #20
base: master
Are you sure you want to change the base?
Conversation
With version 3.1.0, when an event was created all exceptions would exist under each event. This caused issues for me when there were recurrences with the same start times. The updated code passes in only the exceptions related to this particular UID.
When parsing invalid dates, passing in exceptions throws an exception. fall back to using parent when invalid dates are present.
When will there be recurrences with the same start times? do you have an example ics? |
Sorry, my explanation could have been better. If one of these events has an exception goofy things happen because the recurrence-id is based on the timestamp. Without my change, all exceptions belong to every event. If you limit the exceptions to only the ones with the correct UID, then the exceptions will refer to the correct event. Using the attached events.ics (Which has two events with the same recurring schedule, but one of the Weekly Men's Ladder has an exception for a change in the description), with the current code, I process the calendar for the next month and I see: With my updated code there is: |
Ok cool. I think we should have some tests for this. |
@jrdaepi, this seems legit. Could you share the ics file where this edge-case occurs? |
With version 3.1.0, when an event was created all exceptions would exist under each event. This caused issues for me when there were recurrences with the same start times. The updated code passes in only the exceptions related to this particular UID.