Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 9.10.* #904

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

toku-sa-n
Copy link
Collaborator

Description of the PR

Fixes: #890

Checklist

@mihaimaruseac
Copy link
Owner

I'm thinking of doing just one more release with GHC 8 then dropping it. Would that help for this?

@toku-sa-n
Copy link
Collaborator Author

toku-sa-n commented May 27, 2024

I'm thinking of doing just one more release with GHC 8 then dropping it. Would that help for this?

Unfortunately, no. Adding support for a new GHC version is cumbersome with or without keeping support for older GHCs.
Sorry for being late, but I'll complete this PR within a week.

@mihaimaruseac
Copy link
Owner

Oh, no, no worries about being late. I didn't add a comment to say you're late on this, take as much time as you need. I'm really happy you're working on this, I just got some time to look at the repo this weekend as it is a long one.

@toku-sa-n
Copy link
Collaborator Author

Ah, sorry! Actually, I wasn't hurt, and I didn't mean to hurt you. I always appreciate your review and comments. For the comment, I understand that you just asked a question and didn't have any other intention.

@mihaimaruseac
Copy link
Owner

No worries about this at all, it's all good :) I really like seeing your work on this!

@toku-sa-n toku-sa-n marked this pull request as ready for review September 3, 2024 14:44
@toku-sa-n
Copy link
Collaborator Author

So late, and so huge diff, but at least the code now compiles and passes tests with GHC 9.10. I plan to submit clean-up PRs later.

Copy link
Owner

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was heroic amounts of work! Thank you

@mihaimaruseac mihaimaruseac merged commit c2a0dd5 into mihaimaruseac:master Sep 6, 2024
26 checks passed
@toku-sa-n toku-sa-n deleted the GHC9.10 branch September 6, 2024 17:19
@toku-sa-n
Copy link
Collaborator Author

Thanks for the merge! Could you create a new release? A few changes are not released yet, and this might be a good timing for it.

@mihaimaruseac
Copy link
Owner

Sure, I'll do it tomorrow first thing. Thanks for the reminder!

@toku-sa-n
Copy link
Collaborator Author

Thanks for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GHC 9.10
2 participants