-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GHC 9.10.* #904
Support GHC 9.10.* #904
Conversation
I'm thinking of doing just one more release with GHC 8 then dropping it. Would that help for this? |
Unfortunately, no. Adding support for a new GHC version is cumbersome with or without keeping support for older GHCs. |
Oh, no, no worries about being late. I didn't add a comment to say you're late on this, take as much time as you need. I'm really happy you're working on this, I just got some time to look at the repo this weekend as it is a long one. |
Ah, sorry! Actually, I wasn't hurt, and I didn't mean to hurt you. I always appreciate your review and comments. For the comment, I understand that you just asked a question and didn't have any other intention. |
No worries about this at all, it's all good :) I really like seeing your work on this! |
6cff680
to
def8e6e
Compare
So late, and so huge diff, but at least the code now compiles and passes tests with GHC 9.10. I plan to submit clean-up PRs later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was heroic amounts of work! Thank you
Thanks for the merge! Could you create a new release? A few changes are not released yet, and this might be a good timing for it. |
Sure, I'll do it tomorrow first thing. Thanks for the reminder! |
Thanks for the release! |
Description of the PR
Fixes: #890
Checklist