Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option for Erroring when variable is missing #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schotime
Copy link

@schotime schotime commented Jan 6, 2016

Split the erroring so that if the variable doesn't exist, it gives a different error from when the value is undefined. I've added a new option so you can turn either on.

Let me know what you think.

@codecov-io
Copy link

Current coverage is 92.09%

Merging #59 into master will increase coverage by +0.02% as of 00ec8d5

@@            master     #59   diff @@
======================================
  Files          140     140       
  Stmts         4565    4581    +16
  Branches       473     476     +3
  Methods          0       0       
======================================
+ Hit           4203    4219    +16
  Partial        148     148       
  Missed         214     214       

Review entire Coverage Diff as of 00ec8d5

Powered by Codecov. Updated on successful CI builds.

@mikebridge
Copy link
Owner

Thanks, I'll have a few minutes to look at it over the next day or so.

@schotime
Copy link
Author

schotime commented Mar 3, 2016

HI @mikebridge
Where is this at?
What is the status of the project?
Cheers
Adam

@mikebridge
Copy link
Owner

@schotime Sorry, this fell off my plate but I intend to get another release happening soon. I actually already have an implementation for this (#22) but I was hoping to clean up some of the parsing pipeline in the front end before making another release.

@gabrielsadaka gabrielsadaka force-pushed the split_errors_by_variable_and_value branch from e914091 to 1568da7 Compare January 11, 2019 00:07
@codecov-io
Copy link

Codecov Report

Merging #59 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #59      +/-   ##
=========================================
- Coverage    0.02%   0.02%   -0.01%     
=========================================
  Files         140     140              
  Lines        4922    4939      +17     
  Branches      453     456       +3     
=========================================
  Hits            1       1              
- Misses       4921    4938      +17
Impacted Files Coverage Δ
Liquid.NET/src/TemplateContext.cs 0% <0%> (ø) ⬆️
Liquid.NET/src/Constants/IndexDereferencer.cs 0% <0%> (ø) ⬆️
Liquid.NET/src/Utils/LiquidExpressionResult.cs 0% <0%> (ø) ⬆️
Liquid.NET/src/Expressions/VariableReference.cs 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba066fb...1568da7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants