fix jsonindex parse string to int

Signed-off-by: Xianhui.Lin <[email protected]> fix unitest Signed-off-by: Xianhui.Lin <[email protected]> improve Signed-off-by: Xianhui.Lin <[email protected]> fix Signed-off-by: Xianhui.Lin <[email protected]> fix Signed-off-by: Xianhui.Lin <[email protected]> fix go test error Signed-off-by: Xianhui.Lin <[email protected]>
milvus-io · Jan 9, 2025 · 1852709 · 1852709
1 parent 0a18c04
commit 1852709
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/internal/core/src/common/Json.h b/internal/core/src/common/Json.h
@@ -241,10 +241,6 @@ class Json {
     template <typename T>
     value_result<T>
     at(uint16_t offset, uint16_t length) const {
-        if constexpr (std::is_same_v<T, std::string_view> ||
-                      std::is_same_v<T, std::string>) {
-            return value_result<T>(T(data_.data() + offset, length));
-        }
         return doc(offset, length).get<T>();
     }
 

diff --git a/internal/indexnode/index_test.go b/internal/indexnode/index_test.go
@@ -35,7 +35,6 @@ func generateTestSchema() *schemapb.CollectionSchema {
 		{FieldID: 106, Name: "varchar", DataType: schemapb.DataType_VarChar},
 		{FieldID: 107, Name: "string", DataType: schemapb.DataType_String},
 		{FieldID: 108, Name: "array", DataType: schemapb.DataType_Array},
-		{FieldID: 109, Name: "json", DataType: schemapb.DataType_JSON},
 		{FieldID: 110, Name: "int32", DataType: schemapb.DataType_Int32},
 		{FieldID: 111, Name: "floatVector", DataType: schemapb.DataType_FloatVector, TypeParams: []*commonpb.KeyValuePair{
 			{Key: common.DimKey, Value: "8"},

diff --git a/internal/indexnode/task_stats.go b/internal/indexnode/task_stats.go
@@ -332,7 +332,8 @@ func (st *statsTask) Execute(ctx context.Context) error {
 			log.Ctx(ctx).Warn("stats wrong, failed to create text index", zap.Error(err))
 			return err
 		}
-	} else if st.req.GetSubJobType() == indexpb.StatsSubJob_JsonKeyIndexJob {
+	}
+	if st.req.GetSubJobType() == indexpb.StatsSubJob_Sort || st.req.GetSubJobType() == indexpb.StatsSubJob_JsonKeyIndexJob {
 		err = st.createJSONKeyIndex(ctx,
 			st.req.GetStorageConfig(),
 			st.req.GetCollectionID(),