fix jsonindex parse string to int

Signed-off-by: Xianhui.Lin <[email protected]> fix unitest Signed-off-by: Xianhui.Lin <[email protected]>
milvus-io · Jan 8, 2025 · 46d0809 · 46d0809
1 parent 24c1e95
commit 46d0809
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/internal/core/src/common/Json.h b/internal/core/src/common/Json.h
@@ -191,7 +191,8 @@ class Json {
 
         // it's always safe to add the padding,
         // as we have allocated the memory with this padding
-        auto doc = parser.parse(data_.data() + offset, length);
+        auto doc = parser.parse(
+            data_.data() + offset, length, length + simdjson::SIMDJSON_PADDING);
         AssertInfo(doc.error() == simdjson::SUCCESS,
                    "failed to parse the json {}: {}",
                    std::string(data_.data() + offset, length),
@@ -241,10 +242,6 @@ class Json {
     template <typename T>
     value_result<T>
     at(uint16_t offset, uint16_t length) const {
-        if constexpr (std::is_same_v<T, std::string_view> ||
-                      std::is_same_v<T, std::string>) {
-            return value_result<T>(T(data_.data() + offset, length));
-        }
         return doc(offset, length).get<T>();
     }
 

diff --git a/internal/core/src/index/JsonKeyInvertedIndex.cpp b/internal/core/src/index/JsonKeyInvertedIndex.cpp
@@ -82,7 +82,7 @@ JsonKeyInvertedIndex::TravelJson(const char* json,
     } else if (current.type == JSMN_STRING) {
         Assert(current.size == 0);
         AddInvertedRecord(
-            path, offset, current.start, current.end - current.start);
+            path, offset, current.start - 1, current.end - current.start + 1);
         index++;
     }
 }

diff --git a/internal/indexnode/task_stats.go b/internal/indexnode/task_stats.go
@@ -332,7 +332,8 @@ func (st *statsTask) Execute(ctx context.Context) error {
 			log.Ctx(ctx).Warn("stats wrong, failed to create text index", zap.Error(err))
 			return err
 		}
-	} else if st.req.GetSubJobType() == indexpb.StatsSubJob_JsonKeyIndexJob {
+	}
+	if st.req.GetSubJobType() == indexpb.StatsSubJob_Sort || st.req.GetSubJobType() == indexpb.StatsSubJob_JsonKeyIndexJob {
 		err = st.createJSONKeyIndex(ctx,
 			st.req.GetStorageConfig(),
 			st.req.GetCollectionID(),