Skip to content

Commit

Permalink
remove sealsegment chunknum assert
Browse files Browse the repository at this point in the history
Signed-off-by: Xianhui.Lin <[email protected]>
  • Loading branch information
JsDove committed Jan 6, 2025
1 parent 42d5114 commit cb6a311
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion internal/core/src/exec/expression/BinaryRangeExpr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ PhyBinaryRangeFilterExpr::ExecRangeVisitorImplForJsonForIndex() {
using GetType = std::conditional_t<std::is_same_v<ValueType, std::string>,
std::string_view,
ValueType>;
Assert(segment_->type() == SegmentType::Sealed && num_data_chunk_ == 1);
Assert(segment_->type() == SegmentType::Sealed);
auto real_batch_size = current_data_chunk_pos_ + batch_size_ > active_count_
? active_count_ - current_data_chunk_pos_
: batch_size_;
Expand Down
2 changes: 1 addition & 1 deletion internal/core/src/exec/expression/ExistsExpr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ PhyExistsFilterExpr::EvalJsonExistsForDataSegment(OffsetVector* input) {

VectorPtr
PhyExistsFilterExpr::EvalJsonExistsForDataSegmentForIndex() {
Assert(segment_->type() == SegmentType::Sealed && num_data_chunk_ == 1);
Assert(segment_->type() == SegmentType::Sealed);
auto real_batch_size = current_data_chunk_pos_ + batch_size_ > active_count_
? active_count_ - current_data_chunk_pos_
: batch_size_;
Expand Down
12 changes: 6 additions & 6 deletions internal/core/src/exec/expression/JsonContainsExpr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ PhyJsonContainsFilterExpr::ExecJsonContainsByKeyIndex() {
std::conditional_t<std::is_same_v<ExprValueType, std::string>,
std::string_view,
ExprValueType>;
Assert(segment_->type() == SegmentType::Sealed && num_data_chunk_ == 1);
Assert(segment_->type() == SegmentType::Sealed);
auto real_batch_size = current_data_chunk_pos_ + batch_size_ > active_count_
? active_count_ - current_data_chunk_pos_
: batch_size_;
Expand Down Expand Up @@ -498,7 +498,7 @@ PhyJsonContainsFilterExpr::ExecJsonContainsArray(OffsetVector* input) {

VectorPtr
PhyJsonContainsFilterExpr::ExecJsonContainsArrayByKeyIndex() {
Assert(segment_->type() == SegmentType::Sealed && num_data_chunk_ == 1);
Assert(segment_->type() == SegmentType::Sealed);
auto real_batch_size = current_data_chunk_pos_ + batch_size_ > active_count_
? active_count_ - current_data_chunk_pos_
: batch_size_;
Expand Down Expand Up @@ -742,7 +742,7 @@ PhyJsonContainsFilterExpr::ExecJsonContainsAllByKeyIndex() {
std::conditional_t<std::is_same_v<ExprValueType, std::string>,
std::string_view,
ExprValueType>;
Assert(segment_->type() == SegmentType::Sealed && num_data_chunk_ == 1);
Assert(segment_->type() == SegmentType::Sealed);
auto real_batch_size = current_data_chunk_pos_ + batch_size_ > active_count_
? active_count_ - current_data_chunk_pos_
: batch_size_;
Expand Down Expand Up @@ -960,7 +960,7 @@ PhyJsonContainsFilterExpr::ExecJsonContainsAllWithDiffType(

VectorPtr
PhyJsonContainsFilterExpr::ExecJsonContainsAllWithDiffTypeByKeyIndex() {
Assert(segment_->type() == SegmentType::Sealed && num_data_chunk_ == 1);
Assert(segment_->type() == SegmentType::Sealed);
auto real_batch_size = current_data_chunk_pos_ + batch_size_ > active_count_
? active_count_ - current_data_chunk_pos_
: batch_size_;
Expand Down Expand Up @@ -1186,7 +1186,7 @@ PhyJsonContainsFilterExpr::ExecJsonContainsAllArray(OffsetVector* input) {

VectorPtr
PhyJsonContainsFilterExpr::ExecJsonContainsAllArrayByKeyIndex() {
Assert(segment_->type() == SegmentType::Sealed && num_data_chunk_ == 1);
Assert(segment_->type() == SegmentType::Sealed);
auto real_batch_size = current_data_chunk_pos_ + batch_size_ > active_count_
? active_count_ - current_data_chunk_pos_
: batch_size_;
Expand Down Expand Up @@ -1397,7 +1397,7 @@ PhyJsonContainsFilterExpr::ExecJsonContainsWithDiffType(OffsetVector* input) {

VectorPtr
PhyJsonContainsFilterExpr::ExecJsonContainsWithDiffTypeByKeyIndex() {
Assert(segment_->type() == SegmentType::Sealed && num_data_chunk_ == 1);
Assert(segment_->type() == SegmentType::Sealed);
auto real_batch_size = current_data_chunk_pos_ + batch_size_ > active_count_
? active_count_ - current_data_chunk_pos_
: batch_size_;
Expand Down
2 changes: 1 addition & 1 deletion internal/core/src/exec/expression/TermExpr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ PhyTermFilterExpr::ExecJsonInVariableByKeyIndex() {
using GetType = std::conditional_t<std::is_same_v<ValueType, std::string>,
std::string_view,
ValueType>;
Assert(segment_->type() == SegmentType::Sealed && num_data_chunk_ == 1);
Assert(segment_->type() == SegmentType::Sealed);
auto real_batch_size = current_data_chunk_pos_ + batch_size_ > active_count_
? active_count_ - current_data_chunk_pos_
: batch_size_;
Expand Down

0 comments on commit cb6a311

Please sign in to comment.