Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add json key inverted index in stats for optimization #38039

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

fix jsonindex parse string to int

ac45a92
Select commit
Loading
Failed to load commit list.
Open

enhance: Add json key inverted index in stats for optimization #38039

fix jsonindex parse string to int
ac45a92
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 9, 2025 in 1s

68.73% (target 77.00%)

View this Pull Request on Codecov

68.73% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 36.68076% with 599 lines in your changes missing coverage. Please review.

Project coverage is 68.73%. Comparing base (3bcdd92) to head (ac45a92).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/core/src/exec/expression/JsonContainsExpr.cpp 4.04% 285 Missing ⚠️
internal/core/src/exec/expression/UnaryExpr.cpp 3.44% 56 Missing ⚠️
internal/core/src/indexbuilder/index_c.cpp 0.00% 42 Missing ⚠️
...ernal/core/src/exec/expression/BinaryRangeExpr.cpp 5.55% 34 Missing ⚠️
internal/core/src/exec/expression/TermExpr.cpp 8.33% 33 Missing ⚠️
internal/core/src/segcore/segment_c.cpp 0.00% 33 Missing ⚠️
internal/core/src/common/jsmn.h 78.52% 32 Missing ⚠️
internal/core/src/exec/expression/ExistsExpr.cpp 6.66% 28 Missing ⚠️
internal/core/src/index/JsonKeyInvertedIndex.cpp 88.80% 15 Missing ⚠️
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 0.00% 14 Missing ⚠️
... and 4 more

❗ There is a different number of reports uploaded between BASE (3bcdd92) and HEAD (ac45a92). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3bcdd92) HEAD (ac45a92)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38039       +/-   ##
===========================================
- Coverage   81.16%   68.73%   -12.43%     
===========================================
  Files        1395      299     -1096     
  Lines      197215    27492   -169723     
===========================================
- Hits       160065    18896   -141169     
+ Misses      31545     8596    -22949     
+ Partials     5605        0     -5605     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.73% <36.68%> (-0.92%) ⬇️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/common/Json.h 75.00% <100.00%> (+7.09%) ⬆️
...nternal/core/src/exec/expression/BinaryRangeExpr.h 94.00% <ø> (ø)
internal/core/src/exec/expression/ExistsExpr.h 100.00% <ø> (ø)
internal/core/src/exec/expression/Expr.h 70.42% <100.00%> (+0.42%) ⬆️
...ternal/core/src/exec/expression/JsonContainsExpr.h 100.00% <ø> (ø)
internal/core/src/exec/expression/TermExpr.h 85.71% <ø> (ø)
internal/core/src/exec/expression/UnaryExpr.h 68.51% <ø> (ø)
internal/core/src/index/JsonKeyInvertedIndex.h 100.00% <100.00%> (ø)
internal/core/src/segcore/SegmentInterface.h 71.15% <ø> (ø)
internal/core/src/segcore/SegmentSealed.h 100.00% <ø> (ø)
... and 17 more

... and 1102 files with indirect coverage changes