Support new Bulletproof rewind scheme #2848
Conversation
|
@cadmuspeverell thanks for checking the code, however I did some big refactoring on it. I decided that the keychain should be a general key derivation tool, it shouldn't even be aware of the fact of "legacy" proofs. This is why I created a Regarding switch commitments: I agree in general switch commitments should be used. However in some very specific scenario's wallet implementators might not want to use them. For this reason and having the possibility to move to a different scheme in the future I added a |
|
Still a ways to go, but I've had a look over it and absolutely happy with the approach, I likely would have done something similar. Totally in agreement with not loading up the keychain with too much more functionality at this stage (given we've been talking a bit about where it should ultimately go) |
jaspervdm
changed the title
jaspervdm
changed the title
* create 2.0.0 branch * fix humansize version * update grin.yml version * PoW HardFork (#2866) * allow version 2 blocks for next 6 months * add cuckarood.rs with working tests * switch cuckaroo to cuckarood at right heights * reorder to reduce conditions * remove _ prefix on used args; fix typo * Make Valid Header Version dependant on ChainType * Rustfmt * Add tests, uncomment header v2 * Rustfmt * Add FLOONET_FIRST_HARD_FORK height and simplify logic * assume floonet stays closer to avg 60s block time * move floonet hf forward by half a day * update version in new block when previous no longer valid * my next commit:-) * micro optimization * Support new Bulletproof rewind scheme (#2848) * Update keychain with new rewind scheme * Refactor: proof builder trait * Update tests, cleanup * rustfmt * Move conversion of SwitchCommitmentType * Add proof build trait to tx builders * Cache hashes in proof builders * Proof builder tests * Add ViewKey struct * Fix some warnings * Zeroize proof builder secrets on drop * Modify mine_block to use wallet V2 API (#2892) * update mine_block to use V2 wallet API * rustfmt * Add version endpoint to node API, rename pool/push (#2897) * add node version API, tweak pool/push parameter * rustfmt * Upate version api call (#2899) * Update version number for next (potential) release * zeroize: Upgrade to v0.9 (#2914) * zeroize: Upgrade to v0.9 * missed Cargo.lock * [PENDING APPROVAL] put phase outs of C32 and beyond on hold (#2714) * put phase outs of C32 and beyond on hold * update tests for phaseouts on hold * Don't wait for p2p-server thread (#2917) Currently p2p.stop() stops and wait for all peers to exit, that's basically all we need. However we also run a TCP listener in this thread which is blocked on `accept` most of the time. We do an attempt to stop it but it would work only if we get an incoming connection during the shutdown, which is a week guarantee. This fix remove joining to p2p-server thread, it stops all peers and makes an attempt to stop the listener. Fixes [#2906] * rustfmt
Changes to the keychain and builders that are needed for mimblewimble/grin-wallet#105.
I introduce a new
ProofBuildtrait, that is used in building and rewinding a proof. At the moment there are two of them,LegacyProofBuilderandProofBuilder. Wallets can supply the transaction build functions with any struct that implementsProofBuild.grin-walletv2.0.0 will only useProofBuilderfor creating new outputs, but useLegacyProofBuilderto rewind proofs before the hard fork height.I also did some refactoring around switch commitments. With the new rewind scheme there is a version byte specifically for the switch commitment, which means we have the possibility to turn switch commitments off or use a different type for specific outputs, without requiring additional grinding.
For now all outputs that are created will use the
Regulartype. In the future we could have full support on the wallet level for this, but this will have to be done in another PR.This PR also has a
ViewKeystruct, that can be used to scan the chain. Currently it cannot detect switch commitment outputs because it requires 2 extra functions to be added to libsecp. See here for more information