Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new lints for flutter 3.24.5, dart 3.5.4 and metrics 5.7.6 #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add new lints for flutter 3.24.5, dart 3.5.4 and metrics 5.7.6 #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7de8798
remove fvm references from repo
paulkastel Dec 31, 2024
35ed77a
Update lint_quido to 1.24.5
paulkastel Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .fvmrc
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions .vscode/settings.json
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 1.24.5

* Lints for Flutter 3.24.5 and Dart 3.5.4
* Lints from dart_metrics version 5.7.6
* :warning: This version is based on discontinued DCM version

## 1.22.3

* Lints for Flutter 3.22.3 and Dart 3.4.4
Expand Down
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ And we just looooove lots of lints. :blue_heart:
For a start please make sure you work with latest version of Flutter & Dart.
```yaml
environment:
sdk: ">=3.4.4 <4.0.0"
flutter: ^3.22.3
sdk: ">=3.5.4 <4.0.0"
flutter: ^3.24.5
```

Then add a dev dependency in your `pubspec.yaml`:
Expand All @@ -40,7 +40,7 @@ or directly in pubspec.yaml

```yaml
dev_dependencies:
lint_quido: 1.22.3
lint_quido: 1.24.5
```

At last in `analysis_options.yaml` add:
Expand Down Expand Up @@ -114,7 +114,7 @@ dependency_overrides:
## Additional information
This is set of sources from which we are getting our linters and about good practices in Dart/Flutter:
- [All Dart lints](https://dart.dev/tools/linter-rules/all)
- [All Dart lints, but this time linter source code](https://github.com/dart-lang/linter/blob/main/example/all.yaml)
- [All Dart lints, but this time linter source code](https://github.com/dart-lang/sdk/blob/main/pkg/linter/example/all.yaml)
- [Customizing static analysis in Dart](https://dart.dev/tools/analysis)
- [Effective Dart: Usage](https://dart.dev/guides/language/effective-dart/usage)
- [Flutter lints](https://github.com/flutter/packages/tree/main/packages/flutter_lints)
Expand All @@ -125,4 +125,4 @@ This is set of sources from which we are getting our linters and about good prac
#### About Miquido
- [About](https://careers.miquido.com/about-us/)
- [Careers](https://careers.miquido.com/job-offers/)
- [Internship at Miquido](https://careers.miquido.com/students/)
- [Internship at Miquido](https://careers.miquido.com/internships/)
6 changes: 3 additions & 3 deletions example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: lint_quido_example
version: 1.22.3
version: 1.24.5
publish_to: none

environment:
sdk: ">=3.4.4 <4.0.0"
flutter: ">=3.22.3"
sdk: ">=3.5.4 <4.0.0"
flutter: ">=3.24.5"

dependencies:
lint_quido:
Expand Down
6 changes: 4 additions & 2 deletions lib/miquido_lints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ linter:
- avoid_bool_literals_in_conditional_expressions
# - avoid_catches_without_on_clauses - Flutter throws _CastError when parsing json fails, so we need to handle both Error and Exception in all API classes
- avoid_catching_errors
# - avoid_classes_with_only_static_members - We know, but somewhat this doesn't fell right and clean
# - avoid_classes_with_only_static_members - We know, but somewhat this doesn't feel right and clean
- avoid_double_and_int_checks
- avoid_dynamic_calls
- avoid_empty_else
Expand Down Expand Up @@ -90,6 +90,7 @@ linter:
- directives_ordering
# - discarded_futures - do not work well with testing tools and cascade operator
- do_not_use_environment
- document_ignores
- empty_catches
- empty_constructor_bodies
- empty_statements
Expand All @@ -102,6 +103,7 @@ linter:
- implicit_call_tearoffs
- implicit_reopen
- invalid_case_patterns
- invalid_runtime_check_with_js_interop_types
- join_return_with_assignment
- leading_newlines_in_multiline_strings
- library_annotations
Expand Down Expand Up @@ -193,6 +195,7 @@ linter:
- type_init_formals
- type_literal_in_constant_pattern
- unawaited_futures
# - unintended_html_in_doc_comment - this gets funky when sees <Object?> or Map<String, dynamic> types in comments
- unnecessary_await_in_return
- unnecessary_brace_in_string_interps
- unnecessary_breaks
Expand Down Expand Up @@ -220,7 +223,6 @@ linter:
- unnecessary_to_list_in_spreads
- unreachable_from_main
- unrelated_type_equality_checks
- unsafe_html
- use_build_context_synchronously
- use_colored_box
- use_decorated_box
Expand Down
6 changes: 3 additions & 3 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: lint_quido
version: 1.22.3
version: 1.24.5
description: Collection of Flutter lints that we use and follow in Miquido
repository: https://github.com/miquido/lint_quido
issue_tracker: https://github.com/miquido/lint_quido/issues
Expand All @@ -11,8 +11,8 @@ topics:
- lints

environment:
sdk: ">=3.4.4 <4.0.0"
flutter: ">=3.22.3"
sdk: ">=3.5.4 <4.0.0"
flutter: ">=3.24.5"

platforms:
android:
Expand Down
Loading