Potentially invalid emoji code (detect preceding alphanumeric character) #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The intention seems to be to detect if there are any alphanumerics on either side of an emoji code. (See #129.)
However, the code as it is currently written only detects the case for alphanumerics after an emoji code.
In other words, the current behaviour is: (以前の動作:)
We change this behaviour as so: (新しい動作:)
Why
Example note text that would trigger this:
Additional info (optional)
We also extract
notRegexpBefore
as it is a pattern seen elsewhere in the code.If this is considered "not a bug" I am happy for this to be closed.